Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cirq_google to import from cirq directly #4156

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

maffoo
Copy link
Contributor

@maffoo maffoo commented Jun 1, 2021

Now that cirq-google is a separate package from cirq-core, we can import cirq like a separate library. We use the top-level cirq namespace wherever possible instead of importing subpackages, and also remove some of the if TYPE_CHECKING guards and unquote cirq type annotations.

@maffoo maffoo requested review from cduck, vtomole and a team as code owners June 1, 2021 23:09
@maffoo maffoo requested a review from tanujkhattar June 1, 2021 23:09
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 1, 2021
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I didn't think of this consequence of the extraction. It looks much cleaner this way - like using the "public API" of the cirq library instead of depending on the package structure. Thanks!

@maffoo maffoo added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 2, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 2, 2021
@CirqBot CirqBot merged commit 0311e17 into master Jun 2, 2021
@CirqBot CirqBot deleted the u/maffoo/cirq-google-imports branch June 2, 2021 17:37
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 2, 2021
@maffoo maffoo mentioned this pull request Jun 3, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Now that cirq-google is a separate package from cirq-core, we can import cirq like a separate library. We use the top-level `cirq` namespace wherever possible instead of importing subpackages, and also remove some of the `if TYPE_CHECKING` guards and unquote cirq type annotations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants