Extract cirq_aqt #4157
Merged
Extract cirq_aqt #4157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
requested review from
cduck,
ma5x,
pschindler,
vtomole and
a team
as code owners
maffoo
reviewed
Jun 3, 2021
|
Thanks for the review @maffoo - ready for another look! |
balopat
added
the
automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
the
automerge
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
dstrain115
approved these changes
Jun 11, 2021
|
I will wait for #4192 to be merged before I merge this. |
balopat
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Extracts cirq.aqt to cirq_aqt.
Also:
- consolidated package building with the `release.yml` job (`dev_tools/packaging/produce-package.sh`)
- consolidated module listing logic in scripts to use the new modules.py utility:
- adds a utility to list modules that can be used from bash scripts as well as python scripts, it parses the setup.py files and can list metadata from that information (in the future we can do mass updates to version files, etc.):
```
source dev_tools/pypath
python3 dev_tools/modules.py --help
```
```
usage: A utility for modules. [-h] {list} ...
optional arguments:
-h, --help show this help message and exit
subcommands:
valid subcommands
{list} additional help
list lists all the modules
```
```
python3 dev_tools/modules.py list --help
```
```
usage: A utility for modules. list [-h] [--mode {folder,package-path}] [--include-parent]
optional arguments:
-h, --help show this help message and exit
--mode {folder,package-path}
'folder' to list root folder for module, 'package-path' for top level python package path
--include-parent whether to include the parent package or not
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts cirq.aqt to cirq_aqt.
Also:
release.ymljob (dev_tools/packaging/produce-package.sh)