Shard isolated notebook tests #4192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
balopat
force-pushed
the
shard_notebook_tests
branch
from
6cf11ff to
8cda526
Compare
Merged
balopat
requested review from
mpharrigan and
viathor
and removed request for
mpharrigan
viathor
approved these changes
Jun 12, 2021
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sharding for isolated notebook tests.
These tests only test notebooks against the stable cirq releases. Hence they depend on 4 things: stable cirq release (which does not change), the notebooks, the dev environment and the notebook test itself.
In case the dev environment changes we want to run all the notebooks to ensure everything is still running. However this can take a long time and has been causing issues already on PRs causing timeout in Github Actions.
Sharding the tests to 4 partitions avoids the timeout. This PR also adds the ability to easily modify the number of partitions from the ci.yml directly.
Fixes #4190.