Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cirq.channel to cirq.kraus #4195

Merged
merged 3 commits into from
Jun 12, 2021
Merged

Rename cirq.channel to cirq.kraus #4195

merged 3 commits into from
Jun 12, 2021

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Jun 12, 2021 •
edited

Also renames cirq.has_channel to cirq.has_kraus.

Context: #4138.

@viathor viathor requested review from cduck, vtomole and a team as code owners June 12, 2021 03:05
@viathor viathor requested a review from dstrain115 June 12, 2021 03:05
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 12, 2021
balopat
balopat approved these changes Jun 12, 2021
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - nit: we'll need to update the protocols.ipynb docs so that they don't refer to the channel protocol

@viathor
Copy link
Collaborator Author

viathor commented Jun 12, 2021

Updated docs/protocols.ipynb. Thanks for catching this!

@viathor viathor merged commit 55873b9 into quantumlib:master Jun 12, 2021
@viathor viathor deleted the kraus branch June 12, 2021 20:33
@viathor viathor mentioned this pull request Jun 15, 2021
Merged
CirqBot pushed a commit that referenced this pull request Jun 15, 2021
@viathor
Rename channel.py to kraus.py (#4204)
b5c0f80 
Follow-up to #4139 and #4195. Fixes #4138.
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@viathor @rht
Rename cirq.channel to cirq.kraus (quantumlib#4195)
f4c2b3b
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@viathor @rht
Rename channel.py to kraus.py (quantumlib#4204)
a5afc6a 
Follow-up to quantumlib#4139 and quantumlib#4195. Fixes quantumlib#4138.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@dstrain115 dstrain115 Awaiting requested review from dstrain115

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@viathor @balopat