Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename channel.py to kraus.py #4204

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Rename channel.py to kraus.py #4204

merged 2 commits into from
Jun 15, 2021

Conversation

viathor
Copy link
Collaborator

@viathor viathor commented Jun 15, 2021

Follow-up to #4139 and #4195. Fixes #4138.

@viathor viathor requested review from cduck, vtomole and a team as code owners June 15, 2021 00:08
@viathor viathor requested a review from maffoo June 15, 2021 00:08
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jun 15, 2021
@balopat balopat added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jun 15, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jun 15, 2021
@CirqBot CirqBot merged commit b5c0f80 into quantumlib:master Jun 15, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jun 15, 2021
@viathor viathor deleted the channel2kraus branch June 15, 2021 00:43
@tanujkhattar
Copy link
Collaborator

@viathor Should we rename it to kraus_protocol.py instead? The naming would be more consistent with unitary_protocol.py and mixture_protocol.py. I can send a PR if there are no concerns.

@viathor
Copy link
Collaborator Author

viathor commented Aug 20, 2021

@tanujkhattar SGTM!

rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@viathor @rht
Rename channel.py to kraus.py (quantumlib#4204)
a5afc6a 
Follow-up to quantumlib#4139 and quantumlib#4195. Fixes quantumlib#4138.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@maffoo maffoo Awaiting requested review from maffoo

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename cirq.channel to cirq.kraus?
4 participants
@viathor @tanujkhattar @balopat @CirqBot