Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean Hamiltonian gate #4309

Merged
merged 49 commits into from Aug 6, 2021
Merged

Boolean Hamiltonian gate #4309

merged 49 commits into from Aug 6, 2021

Conversation

tonybruguier
Copy link
Contributor

Following #4282, the present PR would like to add a gate that allows computing the Hamiltonian from a Boolean expression. Note that while the decomposition is somewhat efficient, more optimizations are possible and planned in a follow-up PR.

tonybruguier and others added 27 commits July 2, 2021 20:58
@tonybruguier
Add an option to build a PauliSum from a Sympy Boolean expressions
6afaa16
@tonybruguier
Attempt fix mypy
5cae633
@tonybruguier
Using from_pauli_strings()
602b6b4
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into bool_ham_to_ps
20191e9
@tonybruguier
Simple BooleanHamiltonian gate
bde6b2a
@tonybruguier
typo
2129e1b
@tonybruguier
Simple BooleanHamiltonian gate
e5beb4a
@tonybruguier
Merge branch 'simple_gate' of github.com:tonybruguier/Cirq into simpl…
3c01374 
…e_gate
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into bool_ham_to_ps
964eab1
@tonybruguier
Simple BooleanHamiltonian gate
27cf62f
@tonybruguier
Merge remote-tracking branch 'refs/remotes/origin/simple_gate' into s…
5bb26cf 
…imple_gate
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into bool_ham_to_ps
93d099f
@tonybruguier
Merge branch 'bool_ham_to_ps' into simple_gate
4751f29
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into bool_ham_to_ps
b40ee23
@tonybruguier
Merge branch 'bool_ham_to_ps' into simple_gate
27e1efe
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into bool_ham_to_ps
26c1644
@tonybruguier
Merge branch 'bool_ham_to_ps' into simple_gate
45ef594
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into bool_ham_to_ps
f611876
@tonybruguier @balopat
Update cirq-core/cirq/ops/linear_combinations.py
40576db 
Co-authored-by: Balint Pato <balopat@users.noreply.github.com>
@tonybruguier
Merge branch 'bool_ham_to_ps' of github.com:tonybruguier/Cirq into bo…
3a4aa72 
…ol_ham_to_ps
@tonybruguier
Add doc
7c0c2b4
@tonybruguier
Merge branch 'bool_ham_to_ps' into simple_gate
a87a146
@tonybruguier
Format nb
0b43c5d
@tonybruguier
Add reference
40501df
@tonybruguier
Merge branch 'master' into bool_ham_to_ps
cf73570
@tonybruguier
Merge branch 'bool_ham_to_ps' into simple_gate
a1495f4
@tonybruguier
Merge branch 'master' of github.com:quantumlib/Cirq into simple_gate
6b07693
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Jul 9, 2021
@tonybruguier tonybruguier marked this pull request as ready for review July 9, 2021 21:56
@tonybruguier tonybruguier mentioned this pull request Jul 28, 2021
Closed
balopat
balopat approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, just found a couple of nits, please add those.

cirq-core/cirq/ops/boolean_hamiltonian.py Outdated Show resolved Hide resolved
cirq-core/cirq/ops/boolean_hamiltonian.py Outdated Show resolved Hide resolved
cirq-core/cirq/ops/boolean_hamiltonian.py Outdated Show resolved Hide resolved
@tonybruguier
Copy link
Contributor Author

Thanks @balopat !
All the suggestions made sense, so I accepted them, merged the main branch, and re-ran the tests.
PTAL.

@balopat balopat added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) labels Aug 5, 2021
@MichaelBroughton MichaelBroughton added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) labels Aug 5, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 6, 2021
@CirqBot CirqBot merged commit e56e15d into quantumlib:master Aug 6, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 6, 2021
@tonybruguier tonybruguier deleted the simple_gate branch August 6, 2021 02:55
@tonybruguier tonybruguier mentioned this pull request Aug 6, 2021
Merged
@cduck cduck mentioned this pull request Aug 6, 2021
Closed
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tonybruguier @rht
Boolean Hamiltonian gate (quantumlib#4309)
69ccd36 
Following quantumlib#4282, the present PR would like to add a gate that allows computing the Hamiltonian from a Boolean expression. Note that while the decomposition is somewhat efficient, more optimizations are possible and planned in a follow-up PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

Assignees

@balopat balopat

Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tonybruguier @balopat @MichaelBroughton @CirqBot