Add ParallelGate and deprecate ParallelGateOperation #4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maffoo
reviewed
Aug 10, 2021
|
|
||
| @pytest.mark.parametrize( | ||
| 'gate, num_copies, qubits', | ||
| ( |
There was a problem hiding this comment.
turbo nit: I would suggest using list for the list of parametrization cases, since it's homogeneous, unlike the tuples for each case. Applies in several places below, too.
There was a problem hiding this comment.
Just to confirm, you mean replacing the outermost "tuple of tuples" with a "list of tuples", i.e.
@pytest.mark.parametrize(
'gate, num_copies, qubits',
[ # List instead of tuple
(cirq.SingleQubitGate(), 2, cirq.LineQubit.range(2)),
(cirq.X ** 0.5, 4, cirq.LineQubit.range(4)),
]
)
This was referenced Aug 11, 2021
CirqBot
added
size: XL
maffoo
reviewed
Aug 12, 2021
…into parallel_gate
maffoo
approved these changes
Aug 20, 2021
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
|
Automerge cancelled: A status check is failing. |
CirqBot
removed
automerge
tanujkhattar
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…quantumlib#4411) I had to deprecate a serializable value in quantumlib#4398 and couldn't find documentation around how to do it. This PR adds the relevant documentation.
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
This PR deprecates `ParallelGateOperation` in favor of a new `ParallelGate` which should be instead. See quantumlib#4358 for more details. This PR also adds support for `ParallleGate` in neutral atoms and pasqal devices, where currently `ParallelGateOperation` is used. The uses of `ParallelGateOperation` will be removed later during deprecation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
ParallelGateOperationin favor of a newParallelGatewhich should be instead. See #4358 for more details.This PR also adds support for
ParallleGatein neutral atoms and pasqal devices, where currentlyParallelGateOperationis used.The uses of
ParallelGateOperationwill be removed later during deprecation.