Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update serialization.md to include deprecation of serializable values #4411

Merged
merged 3 commits into from Aug 11, 2021
Merged

Update serialization.md to include deprecation of serializable values #4411

merged 3 commits into from Aug 11, 2021

Conversation

tanujkhattar
Copy link
Collaborator

I had to deprecate a serializable value in #4398 and couldn't find documentation around how to do it. This PR adds the relevant documentation.

@tanujkhattar tanujkhattar requested review from cduck, vtomole and a team as code owners August 11, 2021 17:52
@google-cla google-cla bot added the cla: yes Makes googlebot stop complaining. label Aug 11, 2021
balopat
balopat approved these changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the docstring to ModuleJsonTestSpec.deprecated as well? :) Thank you!!!

docs/dev/serialization.md Outdated Show resolved Hide resolved
@tanujkhattar tanujkhattar added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 11, 2021
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 11, 2021
@CirqBot CirqBot merged commit 8cba324 into quantumlib:master Aug 11, 2021
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Aug 11, 2021
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@tanujkhattar @rht
Update serialization.md to include deprecation of serializable values (…
e16470b 
…quantumlib#4411)

I had to deprecate a serializable value in quantumlib#4398 and couldn't find documentation around how to do it. This PR adds the relevant documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@NOUIY NOUIY NOUIY approved these changes

@cduck cduck Awaiting requested review from cduck

@vtomole vtomole Awaiting requested review from vtomole

@dstrain115 dstrain115 Awaiting requested review from dstrain115

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tanujkhattar @balopat @NOUIY @CirqBot