-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GridDeviceMetadata: allow qubit pairs in both directions #5241
GridDeviceMetadata: allow qubit pairs in both directions #5241
Conversation
1b5f2b5
to
176a36d
Compare
176a36d
to
7f6375d
Compare
This looks good. We are already sorting QIDs here as per @dstrain115 's comment in the issue (so things like serialization are not order dependent). Since this change is happening in the subtype and not the parent type (DeviceMetadata), how would we feel about just adding the |
df7c037
to
22c3fa1
Compare
Discussed offline. Will instead use a The option of keeping both |
22c3fa1
to
e49b319
Compare
Pushed the latest changes. I opted to keep the My preference is to reuse the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Automerge cancelled: Pull Request is not mergeable. |
…5241) Fixes quantumlib#5169 @MichaelBroughton do you think this API makes sense?
Fixes #5169
@MichaelBroughton do you think this API makes sense?