Remove qid_pairs deprecation. #5290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
requested review from
HGSilveri,
a team,
vtomole,
cduck,
wcourtney and
verult
as code owners
mpharrigan
reviewed
Apr 25, 2022
| @@ -1,13 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
I don't think we're ever supposed to break loading old json data.
Consider loading as a tuple of two qubits and raising a warning
There was a problem hiding this comment.
Changed to be consistent with other "non breaking old loading behavior".
mpharrigan
approved these changes
Apr 27, 2022
MichaelBroughton
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
Removes previously deprecated `qid_pairs` from devices (also SymmetricalQIDPair).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes previously deprecated
qid_pairsfrom devices (also SymmetricalQIDPair).