Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Fourier Checking tutorial #5708

Merged
merged 9 commits into from Jul 12, 2022

Conversation

dstrain115
Copy link
Collaborator

@dstrain115 dstrain115 commented Jul 10, 2022

  • Miscellaenous fixes for Fourier Checking
  • Fix top block was code not text
  • Fix latex blocks in various places
  • Improve docstrings and typing for functions
  • A few miscellaenous wording improvements.

- Change Foxtail to Sycamore since Foxtail is deprecated.
- Add some clarification that instructions are for linux.
- Miscellaenous fixes for Fourier Checking
- Fix top block was code not text
- Fix latex blocks in various places
- Improve docstrings and typing for functions
- A few miscellaenous wording improvements.
@dstrain115 dstrain115 requested review from a team, vtomole and cduck as code owners July 10, 2022 23:05
@dstrain115 dstrain115 requested a review from dabacon July 10, 2022 23:05
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CirqBot CirqBot added the size: M 50< lines changed <250 label Jul 10, 2022
@@ -32,12 +32,10 @@
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still looks off to me. (first line is what?)


Reply via ReviewNB

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is an artifact of ReviewNB. I don't see anything in the source that could cause this, it doesn't appear in the github viewer, and, if you hide previous version in ReviewNB, it disappears. I will commit this and double-check that it doesn't show up on the website, but I think it is just a reviewnb glitch.

Copy link
Collaborator

@dabacon dabacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line still looks messed to me but otherwise LGTM

@dstrain115 dstrain115 added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 12, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 12, 2022
@CirqBot CirqBot merged commit 9caebca into quantumlib:master Jul 12, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 12, 2022
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
- Miscellaenous fixes for Fourier Checking
- Fix top block was code not text
- Fix latex blocks in various places
- Improve docstrings and typing for functions
- A few miscellaenous wording improvements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: M 50< lines changed <250
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants