Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid warning on complex-to-float conversion #5795

Merged
merged 3 commits into from Jul 18, 2022
Merged

Avoid warning on complex-to-float conversion #5795

merged 3 commits into from Jul 18, 2022

Conversation

pavoljuhas
Copy link
Collaborator

Make it clear we want to use the real part.

@pavoljuhas
Silence warning on complex-to-float conversion
8d446be 
Make it clear we want to use the real part.
@pavoljuhas pavoljuhas requested review from a team, vtomole and cduck as code owners July 18, 2022 20:37
@pavoljuhas pavoljuhas requested a review from maffoo July 18, 2022 20:37
@CirqBot CirqBot added the Size: XS <10 lines changed label Jul 18, 2022
@pavoljuhas pavoljuhas changed the title Silence warning on complex-to-float conversion Avoid warning on complex-to-float conversion Jul 18, 2022
vtomole
vtomole approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavoljuhas pavoljuhas added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 18, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 18, 2022
@CirqBot CirqBot merged commit ba27c7e into quantumlib:master Jul 18, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Jul 18, 2022
@pavoljuhas pavoljuhas deleted the fix-casting-complex-to-real branch July 19, 2022 00:58
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
@pavoljuhas @rht
Avoid warning on complex-to-float conversion (quantumlib#5795)
c88828c 
Make it clear we want to use the real part.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtomole vtomole vtomole approved these changes

@cduck cduck Awaiting requested review from cduck

@maffoo maffoo Awaiting requested review from maffoo maffoo was automatically assigned from quantumlib/cirq-maintainers

Assignees
No one assigned
Labels
Size: XS <10 lines changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pavoljuhas @vtomole @CirqBot @tanujkhattar