Added __str__ and __repr__ for MappingManager and pushed name 'MappingMananger' to 'cirq' namespace #5828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammareltigani
added a commit
to ammareltigani/Cirq
that referenced
this pull request
Aug 16, 2022
tanujkhattar
requested changes
Aug 16, 2022
tanujkhattar
requested changes
Aug 17, 2022
tanujkhattar
approved these changes
Aug 18, 2022
ammareltigani
requested review from
tanujkhattar
and removed request for
verult
mpharrigan
approved these changes
Aug 18, 2022
ammareltigani
added a commit
to ammareltigani/Cirq
that referenced
this pull request
Aug 19, 2022
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…gMananger' to 'cirq' namespace (quantumlib#5828) * added __str__ and __repr__ for MappingManager * made MappingManager not serializable * removed unused import * addressed comments * fixed bug with edges not being sorted for graph equality testing * fixed bug with digraphs repr method in MappingManager and added test for it * made MappingManager serializable * removed print statements * ready for merging * nit * fix lint * removed serialization * removed unused imports * fixed nit * removed debug print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves to complete the MappingManager class started in #5823 . It
(1) Adds a str and repr method to MappingManager
(2) Adds value equality to MappingManager
(2) Pushes the MappingManager name to the entire 'cirq' namespace