Created routing utilities subdirectory in cirq-core/transformers and added MappingManager module #5823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
requested changes
Aug 11, 2022
I don't have access to this. Just requested. |
Sorry @vtomole ! Just shared it with you. |
…anager syncing with master
…igani/Cirq into routing-mapping_manager syncing
tanujkhattar
requested changes
Aug 11, 2022
There was a problem hiding this comment.
Looking really good. One last round of comments, mostly around improving docstrings.
@mpharrigan Do you want to take a look as well?
…tead of physical qubits
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…added MappingManager module (quantumlib#5823) * created routing utilities in cirq-core/transformers and added MappingManager module * ran continuous integration checks * addressed first round of comments * typo * remove unused distance matrix * updated shortest_path method * formatting * minor bug fix * made changes to docstring * minor docstring fixes; shortest_path() now returns logical qubits instead of physical qubits * nit Co-authored-by: Tanuj Khattar <tanujkhattar@google.com> Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first in a series to implement qubit routing capabilities in Cirq. It
(1) creates a new subdirectory in cirq-core/transformers named 'routing' where all qubit routing utilities will live
(2) implements a class MappingManager that will serve to keep track of the mapping of logical to physical qubits during a routing process
For more context, see http://tinyurl.com/cirq-qubit-routing