Creates fake grid device for testing qubit connectivity in routing #5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanujkhattar
requested changes
Aug 16, 2022
ammareltigani
force-pushed
the
routing-initial_mapping_device_setup
branch
from
6bca59a
to
7819263
Compare
Yes. All done. |
mpharrigan
reviewed
Aug 17, 2022
ammareltigani
added a commit
to ammareltigani/Cirq
that referenced
this pull request
Aug 19, 2022
tanujkhattar
requested changes
Aug 19, 2022
ammareltigani
requested review from
mpharrigan and
tanujkhattar
and removed request for
verult,
mpharrigan and
tanujkhattar
ammareltigani
requested review from
tanujkhattar
and removed request for
mpharrigan
tanujkhattar
added a commit
that referenced
this pull request
Sep 2, 2022
* added abstract initial mapper and identity initial mapper * added __str__ and __repr__ for MappingManager * minor bug * made MappingManager not serializable * removed unused import * pushed AbstractInitialMapping and IdentityInitialMapping name to 'cirq' namespace; made both classes not serializable * minor lint fix * addressed comments * addressed comments * fixed bug with edges not being sorted for graph equality testing * fixed bug with digraphs repr method in MappingManager and added test for it * addressed some comments * added grid testing device * added grid routing testing device * formatting * added line_initial_mapper and some tests; needs more testing * formatting * formatting * changed interface for LineInitialMapper and added better tests; test for directed graph value equality remaining * addressed comments and added ring device * added test for supportin directed graphs * changed interface for AbstractInitialMapper * formatting * changed RoutingTestingDevice interface; need to change is_isomorphic tests * added hard-coded isomorphism tests * fixed type issue * removed redundant imports * merged with routing testing device PR #5830 * simplified _value_equalit_values_ * addressed comments * removed unused import * pasted routing files * fixed nits * cleaned up circuit transformer class; needs tests * addressed comments * formatting * small fixes * removed unused import * modified test file * debugging * removed print statements * debugging statement * debugging statement * fix * fix * print statement * edges sorting * addressed comments; ready for review * fixed type bug * cleanup * wrote some tests * ready for review * type and lint fixes * working for basic tests * slightly modified _make_circuit_graph() * added some tests * added test for testing valid circuits and fixed bug in _make_circuit_graph() * debugging currently * made dict of dict storing pqubit distances into numpy integer numpy array * made dict of dict storing pqubit distances into numpy integer numpy array * used better cost function that sped up algorithm by a lot * cleaned up a little and added coverage tests * removed unitary testing code; will add it in next PR * fixed lint and type issues * small lint fix * added unitary testing for routed circuits * changed api to accept only a final mapping of a set of qubits to itself * fixed typos * fixed some docstrings, changed __call__ and route_circuit() order, and move a class function to free function * added tests * refactored _get_timesteps() as per suggestion * more fixes * changed construction of two and single qubit ops lists * fixed bug from _get_two_qubit_ops and added unitary testing * addressed comments and refactored _route() function * minor cleanup * addressed comments * made helper functions class variable and passed mapping manager as function argument everywhere * docstring and nomenclature changes Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…uantumlib#5830) * added grid testing device * formatting * addressed comments and added ring device * changed RoutingTestingDevice interface; need to change is_isomorphic tests * added hard-coded isomorphism tests * fixed type issue * addressed comments * removed unused import * fixed nits
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
* added abstract initial mapper and identity initial mapper * added __str__ and __repr__ for MappingManager * minor bug * made MappingManager not serializable * removed unused import * pushed AbstractInitialMapping and IdentityInitialMapping name to 'cirq' namespace; made both classes not serializable * minor lint fix * addressed comments * addressed comments * fixed bug with edges not being sorted for graph equality testing * fixed bug with digraphs repr method in MappingManager and added test for it * addressed some comments * added grid testing device * added grid routing testing device * formatting * added line_initial_mapper and some tests; needs more testing * formatting * formatting * changed interface for LineInitialMapper and added better tests; test for directed graph value equality remaining * addressed comments and added ring device * added test for supportin directed graphs * changed interface for AbstractInitialMapper * formatting * changed RoutingTestingDevice interface; need to change is_isomorphic tests * added hard-coded isomorphism tests * fixed type issue * removed redundant imports * merged with routing testing device PR quantumlib#5830 * simplified _value_equalit_values_ * addressed comments * removed unused import * pasted routing files * fixed nits * cleaned up circuit transformer class; needs tests * addressed comments * formatting * small fixes * removed unused import * modified test file * debugging * removed print statements * debugging statement * debugging statement * fix * fix * print statement * edges sorting * addressed comments; ready for review * fixed type bug * cleanup * wrote some tests * ready for review * type and lint fixes * working for basic tests * slightly modified _make_circuit_graph() * added some tests * added test for testing valid circuits and fixed bug in _make_circuit_graph() * debugging currently * made dict of dict storing pqubit distances into numpy integer numpy array * made dict of dict storing pqubit distances into numpy integer numpy array * used better cost function that sped up algorithm by a lot * cleaned up a little and added coverage tests * removed unitary testing code; will add it in next PR * fixed lint and type issues * small lint fix * added unitary testing for routed circuits * changed api to accept only a final mapping of a set of qubits to itself * fixed typos * fixed some docstrings, changed __call__ and route_circuit() order, and move a class function to free function * added tests * refactored _get_timesteps() as per suggestion * more fixes * changed construction of two and single qubit ops lists * fixed bug from _get_two_qubit_ops and added unitary testing * addressed comments and refactored _route() function * minor cleanup * addressed comments * made helper functions class variable and passed mapping manager as function argument everywhere * docstring and nomenclature changes Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is creates a fake device to be used only for testing qubit connectivity in routing procedures. It only creates grid (square) devices for now in the cirq-core/testing directory. Other device architectures like ring devices will be added in the future.
For more context see, http://tinyurl.com/cirq-qubit-routing