Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up the minimum required version of ply #5890

Merged
merged 2 commits into from Sep 27, 2022

Conversation

pavoljuhas
Copy link
Collaborator

Avoid the test failure in sycamore_gate_test.py such as follows:

$ pytest -x -q cirq-google/cirq_google/ops/sycamore_gate_test.py::test_consistent_protocols
...
        if not optimize:
            if linfo.validate_all():
>               raise SyntaxError("Can't build lexer")
E               SyntaxError: Can't build lexer

/tmp/t39/lib/python3.9/site-packages/ply/lex.py:894: SyntaxError
-------------------------------------------- Captured stderr call --------------------------------------------
ERROR: /tmp/t39/lib/python3.9/site-packages/qiskit/qasm/qasmlexer.py:191: No regular expression defined for rule 't_eof'

Avoid failure in sycamore_gate_test.py as follows:

```
$ pytest -x -q cirq-google/cirq_google/ops/sycamore_gate_test.py::test_consistent_protocols
...
        if not optimize:
            if linfo.validate_all():
>               raise SyntaxError("Can't build lexer")
E               SyntaxError: Can't build lexer

/tmp/t39/lib/python3.9/site-packages/ply/lex.py:894: SyntaxError
-------------------------------------------- Captured stderr call --------------------------------------------
ERROR: /tmp/t39/lib/python3.9/site-packages/qiskit/qasm/qasmlexer.py:191: No regular expression defined for rule 't_eof'
```
@pavoljuhas pavoljuhas requested review from a team, vtomole and cduck as code owners September 26, 2022 21:12
@CirqBot CirqBot added the Size: XS <10 lines changed label Sep 26, 2022
@pavoljuhas pavoljuhas added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Sep 27, 2022
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Sep 27, 2022
@CirqBot CirqBot merged commit 4ce0363 into quantumlib:master Sep 27, 2022
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Sep 27, 2022
@pavoljuhas pavoljuhas deleted the require-ply-3.6 branch September 27, 2022 20:32
rht pushed a commit to rht/Cirq that referenced this pull request May 1, 2023
Avoid the test failure in `sycamore_gate_test.py` such as follows:

```
$ pytest -x -q cirq-google/cirq_google/ops/sycamore_gate_test.py::test_consistent_protocols
...
        if not optimize:
            if linfo.validate_all():
>               raise SyntaxError("Can't build lexer")
E               SyntaxError: Can't build lexer

/tmp/t39/lib/python3.9/site-packages/ply/lex.py:894: SyntaxError
-------------------------------------------- Captured stderr call --------------------------------------------
ERROR: /tmp/t39/lib/python3.9/site-packages/qiskit/qasm/qasmlexer.py:191: No regular expression defined for rule 't_eof'
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants