Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin cirq_rigetti pyquil dependency to pyquil-3.* #6129

Merged
merged 1 commit into from Jun 9, 2023

Conversation

pavoljuhas
Copy link
Collaborator

Problem: pip install cirq --pre may install pyquil-4.0.0rcN which is
incompatible with cirq_rigetti.

Solution: pin the pyquil dependency to "3.*".

Problem: `pip install cirq --pre` may install pyquil-4.0.0rcN which is
incompatible with cirq_rigetti.

Solution: pin the pyquil dependency to "3.*".
@pavoljuhas pavoljuhas requested review from a team, vtomole and cduck as code owners June 9, 2023 18:36
@pavoljuhas pavoljuhas requested a review from dabacon June 9, 2023 18:36
@CirqBot CirqBot added the Size: XS <10 lines changed label Jun 9, 2023
@tanujkhattar
Copy link
Collaborator

Do you know what's causing the incompatibility? We should also reach out to cirq-rigetti maintainers and see if they can fix the dependency issue.

I've also run into a few issues like rigetti/qcs-api-client-python#9 that causes introduces transitive constraints for us which seem unnecessary.

cc @dabacon @dstrain115 Can we reach out to a cirq-rigetti owner and ask for a comment? Maybe Josh?

@pavoljuhas
Copy link
Collaborator Author

This should also unblock our nightly builds of API docs, which currently fail on inconsistent installation of cirq_rigetti.

@pavoljuhas
Copy link
Collaborator Author

Do you know what's causing the incompatibility?

pyquil-4.0.0rcN uses qcs-sdk-python instead of qcs-api-client which is assumed by cirq_rigetti.
While pyquil has no stable release 4, pip install --pre ... enables its rcN versions.

Can we reach out to a cirq-rigetti owner and ask for a comment?

That's a good idea to ask them to adjust cirq_rigetti for the upcoming pyquil-4.

@pavoljuhas pavoljuhas merged commit 24abfa1 into quantumlib:master Jun 9, 2023
36 checks passed
@pavoljuhas pavoljuhas deleted the pin-pyquil-3.N branch June 9, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: XS <10 lines changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants