update(cirq-rigetti): use pyquil v4 #6281
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jselig-rigetti
force-pushed
the
rigetti-use-pyquil-v4
branch
2 times, most recently
from
d8c1e61
to
1787c12
Compare
| raise ValueError(f'Symbols not valid for region name {region_name}') | ||
| qam_execution_result = quantum_computer.qam.run(executable) | ||
| qam_execution_result = quantum_computer.qam.run(executable, memory_map) |
There was a problem hiding this comment.
We need to check for atomic values and wrap them in a list to prevent a breaking change here.
In v3, Program.write_memory accepted atomic values for memory regions of length 1. For example, Program.write_memory("ro", 1) was valid if ro was defined as DECLARE ro BIT[1]. In v4, the new MemoryMap only accepts sequences of values for a memory region, even if that memory region happens to be length 1.
There was a problem hiding this comment.
fixed this in the lines above 👍
|
Hey @jselig-rigetti @MarquessV Can either of you please review rigetti/qcs-api-client-python#12? It's been causing incompatibility issues with Cirq. |
jselig-rigetti
requested review from
vtomole,
cduck and
a team
as code owners
jselig-rigetti
force-pushed
the
rigetti-use-pyquil-v4
branch
from
6ed2e90
to
34dd7f1
Compare
jselig-rigetti
force-pushed
the
rigetti-use-pyquil-v4
branch
2 times, most recently
from
86fa3dc
to
c5f7f3a
Compare
jselig-rigetti
force-pushed
the
rigetti-use-pyquil-v4
branch
from
c5f7f3a
to
48027f6
Compare
|
@jselig-rigetti @MarquessV Hey, how's this PR going? |
|
Hey @vtomole! This PR is ready to review from our perspective. Anything else you need us to do? |
* Create generalized_uniform_superposition_gate.py
Creates a generalized uniform superposition state, $\frac{1}{\sqrt{M}} \sum_{j=0}^{M-1} \ket{j} $ (where 1< M <= 2^n),
using n qubits, according to the Shukla-Vedula algorithm [SV24].
Note: The Shukla-Vedula algorithm [SV24] offers an efficient approach for creation of a generalized uniform superposition
state of the form, $\frac{1}{\sqrt{M}} \sum_{j=0}^{M-1} \ket{j} $, requiring only $O(log_2 (M))$ qubits and $O(log_2 (M))$
gates. This provides an exponential improvement (in the context of reduced resources and complexity) over other approaches in the literature.
Reference:
[SV24] A. Shukla and P. Vedula, “An efficient quantum algorithm for preparation of uniform quantum superposition states,”
Quantum Information Processing, 23(38): pp. 1-32 (2024).
updated-dependencies: - dependency-name: requests dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Noureldin <noureldinyosri@google.com>
* add internal gate to device proto * build protos * tests pass * add docstring * build protos * build protos
- Fix syntax error in `docs/noise/_index.yaml` - Stop including deleted yaml file - Format with the yaml_format Google tool Fixes quantumlib#6587
- Update the stale list of pre-release notebooks by dropping notebooks that work with the last release 1.3.0 - Enable notebook tests that pass at Cirq HEAD - Fix old instructions on installing pre-release cirq - Add missing import to examples/stabilizer_code.ipynb Ref: https://github.com/quantumlib/Cirq/blob/main/docs/dev/notebooks.md
- Avoid passing an empty string argument to `check/format-incremental` when invoked from `check/all` - Improve validation of the git-revision argument in check scripts by allowing git tags that resolve to a commit - Fix invalid use of `?` in egrep pattern - Make check/mypy pass in the dev.env.txt virtual environment
jselig-rigetti
requested review from
mrwojtek,
ma5x,
pschindler,
wcourtney,
verult,
HGSilveri,
dabacon,
ColemanCollins,
nakardo and
gmauricio
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@jselig-rigetti - FYI, I just merged the main branch into jselig-rigetti:rigetti-use-pyquil-v4. It makes it easier to review this PR, otherwise GitHub would think the changes started at the original fork point and would list over 300 changed files to review. |
- allow latest scipy because quimb>=1.18 works with scipy-1.13 (context in #6543) - allow latest rstcheck - fix dependency specification for tensorflow-docs so it works with `uv pip compile` - Enable the current latest versions of notebook, ipykernel, papermill which are only used for notebook tests - Add temporary specifications for notebook-related transitive dependencies to help pip dependency resolver (should be redundant after #6281) Partially fixes #6464
Refactors as necessary to anticipate the release of PyQuil v4. Changes between the RC used here and the eventual full release should be compatible, but leave this MR as a draft until the dependency can be pinned to a full
>=4.0.0release.