Fix notebook failure in CI tests #6218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add quotation marks to `pip install 'cirq-core[contrib]'` and such. Avoid shell globing errors for bash `failglob` or zsh `nomatch` options.
No change in the effective code.
Use separate pip target directory for each notebook test that may pip-install additional packages. Fixes quantumlib#6213
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid interference between notebook tests.
Use separate pip target directory for each notebook test that may
pip-install additional packages. This prevents pip upgrade of numpy in one
notebook breaking another notebook. Even if second notebook downgrades the
numpy package with
!pip install ...command, the high version may bealready loaded in memory and effective until kernel restart.
Quote brackets in pip shell arguments, prevent shell globing errors.
Clean redundant parentheses after @pytest.fixture.
Fixes #6213