Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix notebook failure in CI tests #6218

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Fix notebook failure in CI tests #6218

merged 4 commits into from
Jul 25, 2023

Commits on Jul 25, 2023

  1. Quote brackets in pip shell arguments 

    Add quotation marks to `pip install 'cirq-core[contrib]'` and such.
Avoid shell globing errors for bash `failglob` or zsh `nomatch` options.
    @pavoljuhas
    pavoljuhas committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    2625df0 View commit details
    Browse the repository at this point in the history

  2. Clean redundant parentheses after @pytest.fixture 

    No change in the effective code.
    @pavoljuhas
    pavoljuhas committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d9a9b66 View commit details
    Browse the repository at this point in the history

  3. Avoid interference between notebook tests 

    Use separate pip target directory for each notebook test that
may pip-install additional packages.

Fixes quantumlib#6213
    @pavoljuhas
    pavoljuhas committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    88e7346 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-notebook-failure-in-ci-test

    @pavoljuhas
    pavoljuhas committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6eb3075 View commit details
    Browse the repository at this point in the history