Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ms gate equality #6231

Merged
merged 5 commits into from Aug 7, 2023
Merged

Conversation

richrines1
Copy link
Contributor

fixes #6230 by adding a value_equality decorator to XXPowGate, YYPowGate and ZZPowGate in order to override the distinct_child_types=True configuration they inherit from EigenGate

this mimics what is already done for cirq.XPowGate, cirq.ZPowGate, and cirq.ZPowGate

@richrines1 richrines1 requested review from vtomole, cduck and a team as code owners August 4, 2023 04:52
@CirqBot CirqBot added the size: S 10< lines changed <50 label Aug 4, 2023
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (14baaa5) 97.37% compared to head (5e14535) 97.37%.
Report is 1 commits behind head on master.

❗ Current head 5e14535 differs from pull request most recent head 27e0071. Consider uploading reports for the commit 27e0071 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6231      +/-   ##
==========================================
- Coverage   97.37%   97.37%   -0.01%     
==========================================
  Files        1116     1116              
  Lines       96042    96054      +12     
==========================================
+ Hits        93524    93532       +8     
- Misses       2518     2522       +4     
Files Changed Coverage Δ
cirq-core/cirq/ops/parity_gates.py 98.15% <100.00%> (+0.03%) ⬆️
cirq-core/cirq/ops/parity_gates_test.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@vtomole vtomole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vtomole vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Aug 7, 2023
@tanujkhattar tanujkhattar enabled auto-merge (squash) August 7, 2023 21:27
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Aug 7, 2023
@tanujkhattar tanujkhattar merged commit 5c36dc0 into quantumlib:master Aug 7, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. size: S 10< lines changed <50
Projects
None yet
Development

Successfully merging this pull request may close these issues.

equivalent MSGate and XXPowGate instances don't evaluate as such
4 participants