Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ms gate equality #6231

Merged
merged 5 commits into from
Aug 7, 2023
Merged

fix ms gate equality #6231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76a463a
fix ms gate equality
richrines1 Aug 4, 2023
6b0d38c
update test
richrines1 Aug 4, 2023
0cfe0ff
Merge branch 'master' into ms-equality
richrines1 Aug 4, 2023
5e14535
Merge branch 'master' into ms-equality
richrines1 Aug 5, 2023
27e0071
Merge branch 'master' into ms-equality
tanujkhattar Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions cirq-core/cirq/ops/parity_gates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import cirq


@value.value_equality
class XXPowGate(gate_features.InterchangeableQubitsGate, eigen_gate.EigenGate):
r"""The X-parity gate, possibly raised to a power.

Expand Down Expand Up @@ -133,6 +134,7 @@ def __repr__(self) -> str:
)


@value.value_equality
class YYPowGate(gate_features.InterchangeableQubitsGate, eigen_gate.EigenGate):
r"""The Y-parity gate, possibly raised to a power.

Expand Down Expand Up @@ -237,6 +239,7 @@ def __repr__(self) -> str:
)


@value.value_equality
class ZZPowGate(gate_features.InterchangeableQubitsGate, eigen_gate.EigenGate):
r"""The Z-parity gate, possibly raised to a power.

Expand Down
20 changes: 18 additions & 2 deletions cirq-core/cirq/ops/parity_gates_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,24 @@ def test_trace_distance():

def test_ms_arguments():
eq_tester = cirq.testing.EqualsTester()
eq_tester.add_equality_group(cirq.ms(np.pi / 2), cirq.ops.MSGate(rads=np.pi / 2))
eq_tester.add_equality_group(cirq.XXPowGate(global_shift=-0.5))
eq_tester.add_equality_group(
cirq.ms(np.pi / 2), cirq.ops.MSGate(rads=np.pi / 2), cirq.XXPowGate(global_shift=-0.5)
)
eq_tester.add_equality_group(
cirq.ms(np.pi / 4), cirq.XXPowGate(exponent=0.5, global_shift=-0.5)
)
eq_tester.add_equality_group(cirq.XX)
eq_tester.add_equality_group(cirq.XX**0.5)


def test_ms_equal_up_to_global_phase():
assert cirq.equal_up_to_global_phase(cirq.ms(np.pi / 2), cirq.XX)
assert cirq.equal_up_to_global_phase(cirq.ms(np.pi / 4), cirq.XX**0.5)
assert not cirq.equal_up_to_global_phase(cirq.ms(np.pi / 4), cirq.XX)

assert cirq.ms(np.pi / 2) in cirq.GateFamily(cirq.XX)
assert cirq.ms(np.pi / 4) in cirq.GateFamily(cirq.XX**0.5)
assert cirq.ms(np.pi / 4) not in cirq.GateFamily(cirq.XX)


def test_ms_str():
Expand Down