Integrate StreamManager with run_sweep() #6233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verult
requested review from
wcourtney,
vtomole,
cduck and
a team
as code owners
dstrain115
approved these changes
Aug 4, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6233 +/- ##
==========================================
- Coverage 97.37% 97.37% -0.01%
==========================================
Files 1116 1116
Lines 96042 96157 +115
==========================================
+ Hits 93524 93632 +108
- Misses 2518 2525 +7
☔ View full report in Codecov by Sentry. |
|
Code coverage decreased because |
verult
added a commit
to verult/Cirq
that referenced
this pull request
Aug 15, 2023
This reverts commit 86479ae.
verult
added a commit
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamManagerintroduced in Add StreamManager #6199.QuantumRunStreamsupportsCreateQuantumProgramAndJobrequests, so the implementation here bypassesEngineProgramaltogether, which will continue to use unary RPCs. This also aligns with our eventual goal of removing programs as a resource.ProcessorSampler, the recommended interface to run circuits on QuantumEngine, usesEngine.run_sweep()under the hood.Note: Previous review history is in this PR against my own fork. I wanted to test something with GitHub's workflow, but it totally did not work :)
@dstrain115
cc @maffoo @wcourtney