Integrate StreamManager with run_sweep() #17
Conversation
| ) | ||
|
|
||
| run_sweep = duet.sync(run_sweep_async) | ||
|
|
||
| # TODO update |
There was a problem hiding this comment.
I would either explain what needs to be updated, connect it to a github issue, or just delete the comment.
As is, it does not give much useful information.
Same for below.
There was a problem hiding this comment.
Will do - I left these here as a reminder for myself to implement this in the full PR.
|
|
||
| Sends the request over the Quantum Engine QuantumRunStream bidirectional stream, and returns | ||
| a future for the stream response. The future will be completed with a `QuantumResult` if | ||
| the job is successful; otherwise, it will be completed with a QuantumJob. |
| run_context: any_pb2.Any, | ||
| program_description: Optional[str] = None, | ||
| program_labels: Optional[Dict[str, str]] = None, | ||
| priority: Optional[int] = None, |
There was a problem hiding this comment.
What's this priority about? I don't recall this ever being used. Is it new?
There was a problem hiding this comment.
It's in the existing create_job_async() call: https://github.com/quantumlib/Cirq/blob/master/cirq-google/cirq_google/engine/engine_client.py#L382C40-L382C40
Not sure how it's used today. Happy to remove if we actually don't use this. cc @wcourtney
| ) | ||
|
|
||
| run_sweep = duet.sync(run_sweep_async) | ||
|
|
||
| # TODO update |
There was a problem hiding this comment.
Will do - I left these here as a reminder for myself to implement this in the full PR.
| run_context: any_pb2.Any, | ||
| program_description: Optional[str] = None, | ||
| program_labels: Optional[Dict[str, str]] = None, | ||
| priority: Optional[int] = None, |
There was a problem hiding this comment.
It's in the existing create_job_async() call: https://github.com/quantumlib/Cirq/blob/master/cirq-google/cirq_google/engine/engine_client.py#L382C40-L382C40
Not sure how it's used today. Happy to remove if we actually don't use this. cc @wcourtney
|
I manually tested this. There seems to be some problems on the server side, but after a long time a create job eventually returns a |
|
Added tests and updated docstrings. I also deferred migrations for Ready for full review. Thanks! |
verult
changed the title
* Move AsyncioExecutor to separate file. * Add StreamManager * Fix test failures * Fixed cancellation races and asyncio.Queue loop issue * Remove the redundant unsubscribe * Addressed wcourtney's comments * Fix linter and coverage failures; added done check to _manage_stream_loop_future * Address maffoo's comments
verult
force-pushed
the
stream-client/end-user-integration-no-program
branch
from
a813576
to
316ea64
Compare
…all-to-all connected (quantumlib#6095)
* fix ms gate equality * update test --------- Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
Looking for approval on the general approach first before updating
run_batch()andrun_calibration()and adding tests.StreamManagerintroduced in Add StreamManager quantumlib/Cirq#6199.QuantumRunStreamsupportsCreateQuantumProgramAndJobrequests, so the implementation here bypassesEngineProgramaltogether, which will continue to use unary RPCs. This also aligns with our eventual goal of removing programs as a resource.ProcessorSampler, the recommended interface to run circuits on QuantumEngine, usesEngine.run_sweep()under the hood.@dstrain115