Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci-daily pytest failure #6335

Merged
merged 5 commits into from Oct 31, 2023
Merged

Conversation

pavoljuhas
Copy link
Collaborator

@pavoljuhas pavoljuhas commented Oct 31, 2023

  • Fix requirements installation for Windows
  • Run notebook tests only on Linux platform
  • Run test_isolated_packages on POSIX platforms only

Temporary workaround for #6336

@pavoljuhas pavoljuhas requested review from vtomole, cduck and a team as code owners October 31, 2023 06:23
@pavoljuhas
Copy link
Collaborator Author

Ref: failed ci-daily run https://github.com/quantumlib/Cirq/actions/runs/6700241980

For instant workflow verification.

Revert this commit before submitting the PR.
@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34e8dab) 97.83% compared to head (50e5ce1) 97.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6335   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files        1108     1108           
  Lines       96240    96266   +26     
=======================================
+ Hits        94157    94184   +27     
+ Misses       2083     2082    -1     
Files Coverage Δ
cirq-ft/cirq_ft/algos/and_gate_test.py 100.00% <100.00%> (ø)
...-ft/cirq_ft/algos/apply_gate_to_lth_target_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/generic_select_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/hubbard_model_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/qrom_test.py 100.00% <100.00%> (ø)
...t/cirq_ft/algos/qubitization_walk_operator_test.py 70.37% <100.00%> (+0.75%) ⬆️
cirq-ft/cirq_ft/algos/state_preparation_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/swap_network_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/algos/unary_iteration_gate_test.py 100.00% <100.00%> (ø)
cirq-ft/cirq_ft/infra/gate_with_registers_test.py 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fails on Windows due to a different location of Python scripts.
ci-daily passed at https://github.com/quantumlib/Cirq/actions/runs/6712280403
PR trigger for the workflow is not needed anymore.

This reverts commit 75fca56.
@pavoljuhas
Copy link
Collaborator Author

Note: ci-daily passed for this PR at https://github.com/quantumlib/Cirq/actions/runs/6712280403

@pavoljuhas pavoljuhas merged commit fec68ae into quantumlib:master Oct 31, 2023
35 checks passed
@pavoljuhas pavoljuhas deleted the fix-ci-daily branch October 31, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants