Deprecate Cirq-FT module in favour of Qualtran #6362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6362 +/- ##
==========================================
- Coverage 97.84% 97.80% -0.04%
==========================================
Files 1110 1111 +1
Lines 96690 96878 +188
==========================================
+ Hits 94606 94756 +150
- Misses 2084 2122 +38 ☔ View full report in Codecov by Sentry. |
pavoljuhas
reviewed
Nov 28, 2023
| """Decorator to allow using deprecated classes and functions in Tests and suppress warnings.""" | ||
|
|
||
| @functools.wraps(func) | ||
| def wrapper(*args, **kwargs): |
There was a problem hiding this comment.
I think you can use the patch.dict as follows and remove all the orig_exists / orig_value code below.
Suggested change
| def wrapper(*args, **kwargs): | |
| @unittest.mock.patch.dict(os.environ, ALLOW_DEPRECATION_IN_TEST="True") | |
| def wrapper(*args, **kwargs): |
dstrain115
approved these changes
Nov 28, 2023
pavoljuhas
requested changes
Nov 28, 2023
|
@pavoljuhas That was a good catch, thanks! Deprecated all the remaining classes & methods as well. PTAL! |
mpharrigan
approved these changes
Nov 28, 2023
pavoljuhas
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final step as part of Cirq-FT & Qualtran integration.
cc @dstrain115 @mpharrigan