-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Randomvars #48
Randomvars #48
Conversation
This makes sure they stay in sync with the rv_gen if that is changed after Parameter construction.
I have started in a new 2.1 branch on integrating this idea. However, after thinking about it at length, I have decided to use a factory method At present, the parameters.py file is finished. I have implemented the functionality in a slightly different way that you did (using various python tricks to keep the code clean etc.) Next up is editing the samplers. Here I want to do a few things:
Do you have any further thoughts or requests in this space? |
This sounds reasonable. You may want to add a flag on uncertainties to mark if they are deep or well-characterized, as that won't be identifiable from the distribution alone (well characterized uncertainties can have uniform distributions). |
I have implemented all this drawing from your code in the 2.1 branch |
This is a start of what I am thinking about to address #46, allowing arbitrary distributions. I have not written any unit tests for it yet, nor solved anything about unbounded distributions discussed in #46, however it does pass all existing unit tests and does not break anything as far as I can see.