Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the version of cucumber to 7.15.0 #125

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

bmscomp
Copy link
Member

@bmscomp bmscomp commented Oct 22, 2023

Upgrading the version of cucumber to the last stable version 7.15.0 can bring bug fixing and performance improvements since the last version used in the library

For more details please refer to https://github.com/cucumber/cucumber-jvm/blob/main/CHANGELOG.md

@bmscomp
Copy link
Member Author

bmscomp commented Dec 11, 2023

@gastaldi , Please can you take a look at this pull request, I think upgrading the version of cucumber can bring some value to this extension

Copy link
Member

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll let anyone from the @quarkiverse/quarkiverse-cucumber team review and merge it

@gastaldi gastaldi requested a review from a team December 11, 2023 13:53
@bmscomp
Copy link
Member Author

bmscomp commented Jan 18, 2024

@gastaldi There is already a released stable version 7.15.0 I think it worth to bring it with this pull request

@bmscomp bmscomp changed the title Upgrade the version of cucumber to 7.14.0 Upgrade the version of cucumber to 7.15.0 Jan 18, 2024
@bmscomp
Copy link
Member Author

bmscomp commented Jan 18, 2024

Please any one can consider merging this pull request, I think it's pretty stable

@gastaldi gastaldi merged commit 40ab557 into quarkiverse:main Jan 18, 2024
1 check passed
@gastaldi
Copy link
Member

@all-contributors add @bmscomp for code

Copy link
Contributor

@gastaldi

I've put up a pull request to add @bmscomp! 🎉

@gastaldi
Copy link
Member

@bmscomp are you interested in joining the Quarkiverse community and becoming a maintainer of this extension?

@bmscomp
Copy link
Member Author

bmscomp commented Jan 18, 2024

@gastaldi Yes, and I'll be glad for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants