Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using setup-java and rely on JBang installing Java #217

Closed
gsmet opened this issue Dec 9, 2023 · 0 comments · Fixed by #227
Closed

Avoid using setup-java and rely on JBang installing Java #217

gsmet opened this issue Dec 9, 2023 · 0 comments · Fixed by #227
Assignees
@gsmet

Comments

@gsmet
Copy link
Member

gsmet commented Dec 9, 2023

  • Using setup-java might cause problems as it can override the currently installed Java. Installing Java via JBang will avoid that.
  • Also, we should enforce the Java version (probably using --java 21) as Quarkus 3.7 will require Java 17 soon and that might break some workflows
@gsmet gsmet self-assigned this Dec 9, 2023
gsmet added a commit to gsmet/quarkus-github-action that referenced this issue Dec 16, 2023
@gsmet
Install repository credentials without using setup-java
15f85df 
Also use a specific repository called quarkus-github-action instead of
the default github one, as the github one can have a different name
depending on how you configure setup-java.

Fixes quarkiverse#218
Fixes quarkiverse#217
@gsmet gsmet mentioned this issue Dec 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gsmet gsmet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Install repository credentials without using setup-java gsmet/quarkus-github-action
1 participant
@gsmet