Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the csv-chatbot sample #485

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Improve the csv-chatbot sample #485

merged 2 commits into from
Apr 23, 2024

Conversation

geoand
Copy link
Collaborator

@geoand geoand commented Apr 23, 2024

@geoand
Simplify CSV chatbot ingestion code
fef4767 
The idea here is to use Jackson's CSV capabilities
thus allowing us to eliminate the mapping code
@geoand
Don't hard code the schema in the system message
c279245
@geoand geoand requested a review from jmartisk April 23, 2024 08:40
@geoand geoand requested a review from a team as a code owner April 23, 2024 08:40
jmartisk
jmartisk approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@jmartisk jmartisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool :)

@geoand
Copy link
Collaborator Author

geoand commented Apr 23, 2024

There might be better APIs in Hibernate for this, however I am not really knowledgeable in its internals

@geoand geoand merged commit bd13e0a into main Apr 23, 2024
12 checks passed
@geoand geoand deleted the #472 branch April 23, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartisk jmartisk jmartisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the csv-chatbot sample
2 participants
@geoand @jmartisk