disable antora until having proper working solution #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could we, instead of removing, move it into a profile that isn't enabled by default? |
cescoffier
approved these changes
Apr 24, 2024
|
We probably can make it a profile. I just did simplest thing that works on my machine. I suggest we merge this so build/samples works. Then someone who are able to run it can make pr with profile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #493 and what is related failures like missing classes in test and conflicting 8081 ports.
by removing antora all builds works again on OSX/podman.
My theory is that the antora devservice is assuming volume mounts/permissions can be adjusted from inside container in a portable way - it can't (unfortunately).
Thus it fails somewhat silently - causing the AntoraTest to not shutdown, causing 8081 failures ...why it then result in devui not being able to find classes is beyond me - but that error goes away with this code commented out.