Improve a few things in websockets.adoc #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
commented
Apr 26, 2024
| @@ -4,20 +4,20 @@ include::./includes/attributes.adoc[] | |||
|
|
|||
| Using a chatbot in a WebSockets environment is quite common, which is why the extension provides a few facilities to make such usages as easy as possible. | |||
|
|
|||
| * 1. Start by adding the link:https://quarkus.io/guides/websockets-next-tutorial[quarkus-websockets-next] dependency to your `pom.xml` file: | |||
|
|
|||
| . Start by adding the link:https://quarkus.io/guides/websockets-next-tutorial[quarkus-websockets-next] dependency to your `pom.xml` file: | |||
There was a problem hiding this comment.
This will make the list properly ordered without having to define the numbers.
There was a problem hiding this comment.
For this to work, you really need the + below to make sure the list is seen as one and not several separated lists.
| * 1. Start by adding the link:https://quarkus.io/guides/websockets-next-tutorial[quarkus-websockets-next] dependency to your `pom.xml` file: | ||
|
|
||
| . Start by adding the link:https://quarkus.io/guides/websockets-next-tutorial[quarkus-websockets-next] dependency to your `pom.xml` file: | ||
| + |
There was a problem hiding this comment.
This makes sure the blocks are indented with the list.
| IMPORTANT: `quarkus-websockets-next` is available as of Quarkus 3.9. | ||
|
|
||
| * 2. Annotated your AiService with `@SessionScoped` | ||
|
|
||
| . Annotate your AI service with `@SessionScoped` |
There was a problem hiding this comment.
Annotate was actually what I wanted to fix.
As for AI service, I made it consistent with the notes at the bottom.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.