Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration error in Gemini #558

Merged
merged 1 commit into from
May 9, 2024
Merged

Fix configuration error in Gemini #558

merged 1 commit into from
May 9, 2024

Conversation

exaV
Copy link
Contributor

@exaV exaV commented May 9, 2024 •
edited by geoand
Loading

The path has to be the same as in LangChain4jVertexAiGeminiConfig

@exaV
fix configuration path in ConfigValidationException message
8d39409 
The path has to be the same as in `LangChain4jVertexAiGeminiConfig`
@exaV exaV requested a review from a team as a code owner May 9, 2024 13:44
@exaV exaV mentioned this pull request May 9, 2024
Closed
@exaV
Copy link
Contributor Author

exaV commented May 9, 2024

let me know if you need any tests to be changed.

geoand
geoand approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand changed the title fix configuration path in ConfigValidationException message Fix configuration error in Gemini May 9, 2024
@geoand geoand merged commit d3e1c88 into quarkiverse:main May 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vertex-ai-gemini bad configuration error message
2 participants
@exaV @geoand