Fix update sample version when releasing #596
Conversation
|
Did you run this to see that is make the change we want (to the |
|
Huhm, how could I be so dumb to not notice.. .. for all samples Changing between |
.github/workflows/release.yml
Outdated
| ./mvnw org.codehaus.mojo:versions-maven-plugin:2.16.2:set -DnewVersion=${{steps.metadata.outputs.current-version}} -f samples/chatbot | ||
| ./mvnw org.codehaus.mojo:versions-maven-plugin:2.16.2:set -DnewVersion=${{steps.metadata.outputs.current-version}} -f samples/csv-chatbot | ||
| ./mvnw org.codehaus.mojo:versions-maven-plugin:2.16.2:set -DnewVersion=${{steps.metadata.outputs.current-version}} -f samples/cli-translator | ||
| ./mvnw org.codehaus.mojo:versions-maven-plugin:2.16.2:set -DnewVersion=${{steps.metadata.outputs.current-version}} -f samples/chatbot-easy-rag |
There was a problem hiding this comment.
Probably a good idea to use some bash to automate it?
for module in samples/*; do echo $module; done
Make sure you define the shell as bash.
There was a problem hiding this comment.
I thought about that too, but there's one sample (the jbang one) that isn't maven based so we'd have to exclude it, and that felt ugly enough for me to persuade me to go with hardcoding the list of modules. But of course we can do it.
There was a problem hiding this comment.
If you insist:
for pom in `find samples/ -name pom.xml`; do module=$(dirname "$pom"); echo $module; done
There was a problem hiding this comment.
@iocanel do you want to update the PR as per Guillaume and Jan's suggestions?
There was a problem hiding this comment.
Updated the PR with @gsmet instructions.
There was a problem hiding this comment.
I have added a comment below
iocanel
force-pushed
the
update-samples-fix
branch
from
aafa817
to
d58d8a2
Compare
.github/workflows/release.yml
Outdated
| ./mvnw org.codehaus.mojo:versions-maven-plugin:2.16.2:set -DnewVersion=${{steps.metadata.outputs.current-version}} -pl samples/cli-translator | ||
| ./mvnw org.codehaus.mojo:versions-maven-plugin:2.16.2:set -DnewVersion=${{steps.metadata.outputs.current-version}} -pl samples/chatbot-easy-rag | ||
| for pom in `find samples/ -name pom.xml`; | ||
| ./mvnw org.codehaus.mojo:versions-maven-plugin:2.16.2:set -DnewVersion=${{steps.metadata.outputs.current-version}} -f $(dirname "$pom"); |
There was a problem hiding this comment.
Shouldn't it be
./mvnw org.codehaus.mojo:versions-maven-plugin:2.16.2:update-property -Dproperty=quarkus-langchain4j.version ...
?
There was a problem hiding this comment.
Updated to use set-property.
iocanel
force-pushed
the
update-samples-fix
branch
from
d58d8a2
to
240bee1
Compare
Follow up fix for: #556