-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multi-deployment configuration for Azure OpenAI #598
Allow multi-deployment configuration for Azure OpenAI #598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
My only ask is to not use lambdas as we generally try to avoid them in runtime code
@geoand I removed the lamdas in favor of I suppose the reason for the change is performance? |
Yeah, at some point in the past we saw there was a tiny impact related to lambdas so we decided to try and limit their use in our code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Now all we need is to have the commits squashed 😀
64c367e
to
506e4a8
Compare
Ah, yes. done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
506e4a8
to
9cd4d3c
Compare
I force pushed an update that fixes the formatter complaints |
Relevant to #237, this will allow overriding the following properties per model in the Azure OpenAI configuration
endpoint
resource-name
deployment-name
Example configuration that is now possible:
In the above example, all models in the parent configuration will have the
my-deployment-name
, but the Embedding model will have theanother-deployment-name
specifically as a name.