Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QQE-737 | Make Kafka use KRaft mode #1175

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

fedinskiy
Copy link
Contributor

@fedinskiy fedinskiy commented Jun 20, 2024

Summary

In KRaft mode Zookeper is not used, since brokers communicate to each other directly.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy force-pushed the feature/kraft branch 2 times, most recently from b42da8a to 0733a0c Compare June 21, 2024 12:06
@fedinskiy fedinskiy marked this pull request as ready for review June 21, 2024 12:07
@fedinskiy
Copy link
Contributor Author

run tests

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's alright. I'll need to re-check later today when I have more time and CI is green.

@michalvavrik
Copy link
Member

@fedinskiy can you confirm you run smoke check on SASL_SSL and Kafka SSL scenarios in TS?

@fedinskiy
Copy link
Contributor Author

I have run both Openshift and baremetal tests in framework in all three examples/kafka* nodules. I am running TS tests now

@fedinskiy
Copy link
Contributor Author

Kafka SSL test in TS (messaging-kafka-ssl module) went just fine.

There is a failure in KafkaGratefulShutdownIT (will investigate it next week) and in Snappy tests (they read kafka logs manually, so we need to change the directory)

Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I think it's very good job, but let's wait till next week when you finish TS investigation. Changes LGTM.

In KRaft mode Zookeper is not used, since brokers communicate to each
other directly.
@fedinskiy fedinskiy changed the title QQE-737 | Kafka tests use KRaft mode QQE-737 | Make Kafka use KRaft mode Jun 24, 2024
@michalvavrik
Copy link
Member

run tests

1 similar comment
@michalvavrik
Copy link
Member

run tests

@michalvavrik
Copy link
Member

Failure of the OpenShiftS2iQuickstartUsingDefaultsIT in OCP native mode is not related. Let's improve in follow-up PR's if there are fixes required for TS.

@michalvavrik michalvavrik merged commit a0aa92c into quarkus-qe:main Jun 24, 2024
9 of 10 checks passed
@mjurc mjurc added triage/backport-1.3? Backport to 1.3 branch may be required triage/backport-1.4? Quarkus 3.8 stream labels Jun 29, 2024
@mjurc
Copy link
Member

mjurc commented Jun 29, 2024

This also needs to be backported to the other supported branches too, since this also enables the now supported usage of Kafka in KRaft mode without deprecated Debezium.

@fedinskiy fedinskiy removed triage/backport-1.3? Backport to 1.3 branch may be required triage/backport-1.4? Quarkus 3.8 stream labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants