Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find a proper naming strategy for docker images #609

Closed
fedinskiy opened this issue Apr 21, 2022 · 2 comments
Closed

Find a proper naming strategy for docker images #609

fedinskiy opened this issue Apr 21, 2022 · 2 comments
Labels
priority/low Minor issue. question Further information is requested

Comments

@fedinskiy
Copy link
Contributor

Some of the images we use in the test suite are from redhat registry, others(with the same versions) are from Docker Hub/Quay.io and it is not easy to understand, why we use some version and path in particular. It would be nice to put a bit of order in there.
See #608 (comment) for context

@rsvoboda
Copy link
Member

rsvoboda commented Apr 22, 2022

We need to cover both worlds, it also depends if you are using profile with registry enabled, then you have more RH based images than without the profile.
You enable the registry profile only if you are authenticated against the registry.redhat.io. Many RH images require authentication.
GH Actions are using publicly available images, Jenkins jobs have enabled the profile for images from registry.redhat.io.

@mjurc mjurc added question Further information is requested priority/low Minor issue. labels Aug 4, 2022
@michalvavrik
Copy link
Member

hey @fedinskiy are you happy with Rostislav answer? https://github.com/quarkus-qe/quarkus-test-suite#profiles-overview seems sufficient as for Red Hat registry profile to me and I'm not sure if there is more to document.

My suggestion: I'll close issue. Please feel free to re-open it, but make sure you enhance issue description to make it more actionable (concrete suggestions, point out what we should change or do). Thank you

gtroitsk added a commit to gtroitsk/quarkus-test-suite that referenced this issue Jul 8, 2023
gtroitsk added a commit to gtroitsk/quarkus-test-suite that referenced this issue Jul 8, 2023
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this issue Jul 10, 2023
author Jose Carranza <jcarranz@redhat.com> 1686853189 +0200
committer Jose Carranza <jcarranz@redhat.com> 1688565488 +0200

adding some veretx http coverage related to HttpServer, HttpServerRequest, HttpServerResponse,HttpHeaders

improve form logic

implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario

implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario

keep 999999-SNAPSHOT version

keep 999999-SNAPSHOT version

keep pom as in upstream/main

keep pom as in upstream/main

use of @ApplicationScoped and onStart to deploy HttpVertxReactiveServer, websocket test

reformat code style and add HttpClient test

fix websocket test

redoing tests as quarkus way - just keep vertx HttpClient test

Enable OpenShiftQuickstartIT with snapshot

Adjust GraphQLTelemetryIT to reflect latest updates

Change Quarkus CLI utils to use default streams

Remove todo with outdated Zulip conversation

Bump maven-checkstyle-plugin from 3.2.1 to 3.3.0

Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.1 to 3.3.0.
- [Commits](apache/maven-checkstyle-plugin@maven-checkstyle-plugin-3.2.1...maven-checkstyle-plugin-3.3.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Remove magical constant in PostgresPoolTest

Trailing comma is no longer present in Micrometer Prometheus

See quarkusio/quarkus#30343 for details

Remove PostgreSQL image workaround

Issue quarkus-qe/quarkus-test-framework#641 was solved

Bump quarkiverse.pact.version from 1.0.0.Final to 1.0.1.Final

Bumps `quarkiverse.pact.version` from 1.0.0.Final to 1.0.1.Final.

Updates `quarkus-pact-provider` from 1.0.0.Final to 1.0.1.Final

Updates `quarkus-pact-consumer` from 1.0.0.Final to 1.0.1.Final

---
updated-dependencies:
- dependency-name: io.quarkiverse.pact:quarkus-pact-provider
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: io.quarkiverse.pact:quarkus-pact-consumer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Update deprecated usage of RestSseElementType

* Updating test app to use RestStreamElementType rather than the deprecated
  RestSseElementType. This also fixes failure of the Kafka tests running
  with the test app.

Bump quarkus.qe.framework.version from 1.3.0.Beta16 to 1.3.0.Beta17

Bumps `quarkus.qe.framework.version` from 1.3.0.Beta16 to 1.3.0.Beta17.

Updates `quarkus-test-parent` from 1.3.0.Beta16 to 1.3.0.Beta17
- [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases)
- [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md)
- [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17)

Updates `quarkus-test-containers` from 1.3.0.Beta16 to 1.3.0.Beta17
- [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases)
- [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md)
- [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17)

Updates `quarkus-test-openshift` from 1.3.0.Beta16 to 1.3.0.Beta17
- [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases)
- [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md)
- [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17)

---
updated-dependencies:
- dependency-name: io.quarkus.qe:quarkus-test-parent
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.quarkus.qe:quarkus-test-containers
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: io.quarkus.qe:quarkus-test-openshift
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump tj-actions/changed-files from 35.9.2 to 36.0.8

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35.9.2 to 36.0.8.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v35.9.2...v36.0.8)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Add option to debug Quarkus Test Suite

Rename PostgreSQL image instances

Extends quarkus-qe#1240

Bump checkstyle from 10.11.0 to 10.12.0

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.11.0 to 10.12.0.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-10.11.0...checkstyle-10.12.0)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Change PostgresqlService instances to use default properties

Related issue quarkus-qe/quarkus-test-framework#455 was fixed

Bump tj-actions/changed-files from 36.0.8 to 36.0.10

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 36.0.8 to 36.0.10.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v36.0.8...v36.0.10)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Use only major version tj-actions/changed-files

Fix failing HTTP DEV mode log checks

Disable DomainSocketIT due to upstream bug

Bump formatter-maven-plugin from 2.21.0 to 2.23.0

Bumps [formatter-maven-plugin](https://github.com/revelc/formatter-maven-plugin) from 2.21.0 to 2.23.0.
- [Changelog](https://github.com/revelc/formatter-maven-plugin/blob/main/CHANGELOG.md)
- [Commits](revelc/formatter-maven-plugin@formatter-maven-plugin-2.21.0...formatter-maven-plugin-2.23.0)

---
updated-dependencies:
- dependency-name: net.revelc.code.formatter:formatter-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Verify OIDC service app dont generate enc. key

Revert "Fix failing HTTP DEV mode log checks"

This reverts commit 82bba48.

Verify REST Client Reactive support truststore

Replace OpenTracing with OTel in javaee-like-getting-started

The goal is to have a module which combines OTel with other extensions,
namely `smallrye-jwt` and `smallrye-openapi`.

keep DomainSocketIT as in the upstream repo

fix httpClient test

Bump quarkus-qpid-jms from 2.2.0 to 2.3.0

Bumps [quarkus-qpid-jms](https://github.com/amqphub/quarkus-qpid-jms) from 2.2.0 to 2.3.0.
- [Commits](amqphub/quarkus-qpid-jms@2.2.0...2.3.0)

---
updated-dependencies:
- dependency-name: org.amqphub.quarkus:quarkus-qpid-jms
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Flyway now requires dedicated dep for Oracle

Migrate deprecated configuration properties for Artemis URL and kafka

Remove todo with resolved issue from pom

Issue was quarkus-qe#609 was closed
jcarranzan added a commit to jcarranzan/quarkus-test-suite that referenced this issue Jul 10, 2023
Bump quarkus-qpid-jms from 2.2.0 to 2.3.0

Bumps [quarkus-qpid-jms](https://github.com/amqphub/quarkus-qpid-jms) from 2.2.0 to 2.3.0.
- [Commits](amqphub/quarkus-qpid-jms@2.2.0...2.3.0)

---
updated-dependencies:
- dependency-name: org.amqphub.quarkus:quarkus-qpid-jms
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Flyway now requires dedicated dep for Oracle

Migrate deprecated configuration properties for Artemis URL and kafka

Remove todo with resolved issue from pom

Issue was quarkus-qe#609 was closed

Fix Workshop external app test for Ghost

Isolate AgroalPoolTest to one datasource

parent ff57517
author Jose Carranza <jcarranz@redhat.com> 1686853189 +0200
committer Jose Carranza <jcarranz@redhat.com> 1688565488 +0200

adding some veretx http coverage related to HttpServer, HttpServerRequest, HttpServerResponse,HttpHeaders

improve form logic

implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario

implement ServerWebSocket logic, remove RestEasy annotation not needed here, and use @QuarkusScenario

keep 999999-SNAPSHOT version

keep 999999-SNAPSHOT version

keep pom as in upstream/main

keep pom as in upstream/main

use of @ApplicationScoped and onStart to deploy HttpVertxReactiveServer, websocket test

reformat code style and add HttpClient test

fix websocket test

redoing tests as quarkus way - just keep vertx HttpClient test

Enable OpenShiftQuickstartIT with snapshot

Adjust GraphQLTelemetryIT to reflect latest updates

Change Quarkus CLI utils to use default streams

Remove todo with outdated Zulip conversation

Bump maven-checkstyle-plugin from 3.2.1 to 3.3.0

Bumps [maven-checkstyle-plugin](https://github.com/apache/maven-checkstyle-plugin) from 3.2.1 to 3.3.0.
- [Commits](apache/maven-checkstyle-plugin@maven-checkstyle-plugin-3.2.1...maven-checkstyle-plugin-3.3.0)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-checkstyle-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Remove magical constant in PostgresPoolTest

Trailing comma is no longer present in Micrometer Prometheus

See quarkusio/quarkus#30343 for details

Remove PostgreSQL image workaround

Issue quarkus-qe/quarkus-test-framework#641 was solved

Bump quarkiverse.pact.version from 1.0.0.Final to 1.0.1.Final

Bumps `quarkiverse.pact.version` from 1.0.0.Final to 1.0.1.Final.

Updates `quarkus-pact-provider` from 1.0.0.Final to 1.0.1.Final

Updates `quarkus-pact-consumer` from 1.0.0.Final to 1.0.1.Final

---
updated-dependencies:
- dependency-name: io.quarkiverse.pact:quarkus-pact-provider
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: io.quarkiverse.pact:quarkus-pact-consumer
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Update deprecated usage of RestSseElementType

* Updating test app to use RestStreamElementType rather than the deprecated
  RestSseElementType. This also fixes failure of the Kafka tests running
  with the test app.

Bump quarkus.qe.framework.version from 1.3.0.Beta16 to 1.3.0.Beta17

Bumps `quarkus.qe.framework.version` from 1.3.0.Beta16 to 1.3.0.Beta17.

Updates `quarkus-test-parent` from 1.3.0.Beta16 to 1.3.0.Beta17
- [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases)
- [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md)
- [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17)

Updates `quarkus-test-containers` from 1.3.0.Beta16 to 1.3.0.Beta17
- [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases)
- [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md)
- [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17)

Updates `quarkus-test-openshift` from 1.3.0.Beta16 to 1.3.0.Beta17
- [Release notes](https://github.com/quarkus-qe/quarkus-test-framework/releases)
- [Changelog](https://github.com/quarkus-qe/quarkus-test-framework/blob/main/RELEASE.md)
- [Commits](quarkus-qe/quarkus-test-framework@1.3.0.Beta16...1.3.0.Beta17)

---
updated-dependencies:
- dependency-name: io.quarkus.qe:quarkus-test-parent
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: io.quarkus.qe:quarkus-test-containers
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: io.quarkus.qe:quarkus-test-openshift
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Bump tj-actions/changed-files from 35.9.2 to 36.0.8

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 35.9.2 to 36.0.8.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v35.9.2...v36.0.8)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Add option to debug Quarkus Test Suite

Rename PostgreSQL image instances

Extends quarkus-qe#1240

Bump checkstyle from 10.11.0 to 10.12.0

Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 10.11.0 to 10.12.0.
- [Release notes](https://github.com/checkstyle/checkstyle/releases)
- [Commits](checkstyle/checkstyle@checkstyle-10.11.0...checkstyle-10.12.0)

---
updated-dependencies:
- dependency-name: com.puppycrawl.tools:checkstyle
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Change PostgresqlService instances to use default properties

Related issue quarkus-qe/quarkus-test-framework#455 was fixed

Bump tj-actions/changed-files from 36.0.8 to 36.0.10

Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 36.0.8 to 36.0.10.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v36.0.8...v36.0.10)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Use only major version tj-actions/changed-files

Fix failing HTTP DEV mode log checks

Disable DomainSocketIT due to upstream bug

Bump formatter-maven-plugin from 2.21.0 to 2.23.0

Bumps [formatter-maven-plugin](https://github.com/revelc/formatter-maven-plugin) from 2.21.0 to 2.23.0.
- [Changelog](https://github.com/revelc/formatter-maven-plugin/blob/main/CHANGELOG.md)
- [Commits](revelc/formatter-maven-plugin@formatter-maven-plugin-2.21.0...formatter-maven-plugin-2.23.0)

---
updated-dependencies:
- dependency-name: net.revelc.code.formatter:formatter-maven-plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Verify OIDC service app dont generate enc. key

Revert "Fix failing HTTP DEV mode log checks"

This reverts commit 82bba48.

Verify REST Client Reactive support truststore

Replace OpenTracing with OTel in javaee-like-getting-started

The goal is to have a module which combines OTel with other extensions,
namely `smallrye-jwt` and `smallrye-openapi`.

keep DomainSocketIT as in the upstream repo

fix httpClient test

Bump quarkus-qpid-jms from 2.2.0 to 2.3.0

Bumps [quarkus-qpid-jms](https://github.com/amqphub/quarkus-qpid-jms) from 2.2.0 to 2.3.0.
- [Commits](amqphub/quarkus-qpid-jms@2.2.0...2.3.0)

---
updated-dependencies:
- dependency-name: org.amqphub.quarkus:quarkus-qpid-jms
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Flyway now requires dedicated dep for Oracle

Migrate deprecated configuration properties for Artemis URL and kafka

Remove todo with resolved issue from pom

Issue was quarkus-qe#609 was closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low Minor issue. question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants