Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single HTTP server for gRPC services #1472

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Use single HTTP server for gRPC services #1472

merged 1 commit into from
Oct 20, 2023

Conversation

gtroitsk
Copy link
Member

Summary

Solves issue #1373

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik added the triage/backport-3.2 RHBQ Ghost LTS release label Oct 15, 2023
@gtroitsk
Copy link
Member Author

I will wait to run OC tests as it has failed some. See https://main-jenkins-csb-quarkusqe.apps.ocp-c1.prod.psi.redhat.com/view/all/job/quarkus-main-rhel8-jdk11-openshift-ts-jvm/2/#showFailuresLink

@michalvavrik
Copy link
Member

run tests

michalvavrik
michalvavrik approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait till I manage to resolve OpenShift issues. I'm going to merge this myself when it's done.

@michalvavrik
Copy link
Member

run tests

@michalvavrik
Copy link
Member

Rebased on main in order to get OCP fixed.

@michalvavrik
Copy link
Member

I tested it and io.quarkus.ts.opentelemetry.reactive.OpenShiftOpentelemetryReactiveIT.testContextPropagation native failure is not related.

@michalvavrik michalvavrik merged commit 938f091 into quarkus-qe:main Oct 20, 2023
8 of 9 checks passed
@gtroitsk gtroitsk mentioned this pull request Oct 23, 2023
Merged
9 tasks
@michalvavrik michalvavrik removed the triage/backport-3.2 RHBQ Ghost LTS release label Oct 23, 2023
@gtroitsk gtroitsk mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtroitsk @michalvavrik