hbm2ddl create-schemas doesn't work when setting quarkus.hibernate-orm.database.default-schema

[vu-bui]

Describe the bug

The option quarkus.hibernate-orm.database.generation.create-schemas seems to doesn't work anymore since 2.6.3.Final. I'm not sure if it's caused by Hibernate upgrade or not.

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

Darwin local 21.5.0 Darwin Kernel Version 21.5.0: Thu Apr 21 19:51:22 PDT 2022; root:xnu-8020.120.68.131.2~2/RELEASE_X86_64 x86_64

Output of java -version

openjdk version "11.0.15" 2022-04-19

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.6.3.Final and newer

Build tool (ie. output of mvnw --version or gradlew --version)

Gradle 7.4.2

Additional information

No response

[quarkus-bot]

/cc @Sanne, @gsmet

[yrodiere]

It seems to work in our integration tests:

quarkus/integration-tests/jpa-postgresql/src/main/resources/application.properties

Line 7 in d688bcf

quarkus.hibernate-orm.database.generation.create-schemas=true

quarkus/integration-tests/jpa-postgresql/src/main/java/io/quarkus/it/jpa/postgresql/Person.java

Line 14 in 7c9966f

@Table(schema = "myschema")

quarkus/integration-tests/jpa-postgresql/src/main/java/io/quarkus/it/jpa/postgresql/JPAFunctionalityTestEndpoint.java

Lines 107 to 131 in 7c9966f

	private static void listExistingPersons(EntityManager em) {
	CriteriaBuilder cb = em.getCriteriaBuilder();
	CriteriaQuery<Person> cq = cb.createQuery(Person.class);
	Root<Person> from = cq.from(Person.class);
	cq.select(from).orderBy(cb.asc(from.get("name")));
	TypedQuery<Person> q = em.createQuery(cq);
	List<Person> allpersons = q.getResultList();
	if (allpersons.size() != 3) {
	throw new RuntimeException("Incorrect number of results");
	}
	if (!allpersons.get(0).getName().equals("Gizmo")) {
	throw new RuntimeException("Incorrect order of results");
	}
	StringBuilder sb = new StringBuilder("list of stored Person names:\n\t");
	for (Person p : allpersons) {
	p.describeFully(sb);
	sb.append("\n\t");
	if (p.getStatus() != Status.LIVING) {
	throw new RuntimeException("Incorrect status " + p);
	}
	}
	sb.append("\nList complete.\n");
	System.out.print(sb);
	}

Can you please provide a simple project that reproduces the problem?

Thank you.

[yrodiere]

This other issue suggests the problem is only when quarkus.hibernate-orm.database.generation is set to update. Was that your case?

[yrodiere]

Bump. @vu-bui Can you give us a reproducer, or at least confirm your problem is the same as this one and occurs only when quarkus.hibernate-orm.database.generation is set to update?

[vu-bui]

@yrodiere Sorry for the late reply. I've created a repo here https://github.com/vu-bui/quarkus-hibernate-schema-generation.

What I found out was that quarkus.hibernate-orm.database.generation.create-schemas does not work with quarkus.hibernate-orm.database.default-schema. It works with Quarkus 2.6.2.Final and earlier.

It also works if I specifically define @Table(schema = "")

[yrodiere]

Thanks a lot for the information and reproducer @vu-bui , it does seem related to some changes I'm familiar with. I will have a closer look.

[yrodiere]

After some investigation, the problem seems to be upstream. I reported the problem: https://hibernate.atlassian.net/browse/HHH-16177
I will try to come up with a fix upstream.
Thanks again for the reproducer, that helped a lot.

[yrodiere]

The bug was fixed upstream. It will be fixed in Quarkus as soon as we upgrade to either Hibernate ORM 5.6.16.Final or Hibernate ORM 6.2.0.Final (neither was released yet).

[michalvavrik]

I presume this was closed with #32687, I'll write test in QE test suite, so will verify it later.

[Sanne]

thanks @michalvavrik !

[yrodiere]

I presume this was closed with #32687, I'll write test in QE test suite, so will verify it later.

That's right, I forgot to close this. Thanks!