Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom MicroProfile Config converters #2399

Merged
merged 1 commit into from May 17, 2019
Merged

Support custom MicroProfile Config converters #2399

merged 1 commit into from May 17, 2019

Conversation

sarxos
Copy link
Contributor

@sarxos sarxos commented May 10, 2019

Hello @dmlloyd,

This is a commit I prepared in regards to the problem we discussed on Zulip to address issue #702 you created in the past.

dmlloyd
dmlloyd requested changes May 10, 2019
View reviewed changes
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes.

...ent/src/main/java/io/quarkus/deployment/builditem/ConfigurationCustomConverterBuildItem.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigurationSetup.java Outdated Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigurationSetup.java Outdated Show resolved Hide resolved
@sarxos sarxos force-pushed the master branch 3 times, most recently from 762a464 to ae1c740 Compare May 16, 2019 10:44
gsmet
gsmet reviewed May 16, 2019
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @dmlloyd review it in depth but I added a few cosmetic comments.

core/runtime/src/main/java/io/quarkus/runtime/configuration/ConverterSupport.java Show resolved Hide resolved
core/runtime/src/main/java/io/quarkus/runtime/configuration/ConverterSupport.java Outdated Show resolved Hide resolved
core/runtime/src/test/java/io/quarkus/runtime/configuration/ConverterSupportTest.java Outdated Show resolved Hide resolved
This was referenced May 16, 2019
Closed
Closed
dmlloyd
dmlloyd requested changes May 16, 2019
View reviewed changes
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think after the priorities are added to our converters, this will be ready to go.

core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigurationSetup.java Show resolved Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigurationSetup.java Show resolved Hide resolved
core/runtime/src/main/java/io/quarkus/runtime/configuration/ConverterSupport.java Show resolved Hide resolved
@sarxos
Copy link
Contributor Author

sarxos commented May 17, 2019

Hi @dmlloyd, @gsmet New patchset is ready for next code review iteration. All prior comments are addressed.

@dmlloyd dmlloyd merged commit 5bcaff3 into quarkusio:master May 17, 2019
@dmlloyd
Copy link
Member

dmlloyd commented May 17, 2019

Looks OK, thanks.

@dmlloyd dmlloyd mentioned this pull request May 17, 2019
Closed
@gsmet gsmet added this to the 0.16.0 milestone May 30, 2019
@gsmet gsmet changed the title Support custom MicroProfile Config Converter, refs #702 Support custom MicroProfile Config Converter May 30, 2019
@gsmet gsmet changed the title Support custom MicroProfile Config Converter Support custom MicroProfile Config converters May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet left review comments

@dmlloyd dmlloyd dmlloyd approved these changes

Assignees
No one assigned
Labels
release/noteworthy-feature
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarxos @dmlloyd @gsmet