-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support custom MicroProfile Config converters #2399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes.
...ent/src/main/java/io/quarkus/deployment/builditem/ConfigurationCustomConverterBuildItem.java
Outdated
Show resolved
Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigurationSetup.java
Outdated
Show resolved
Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigurationSetup.java
Outdated
Show resolved
Hide resolved
762a464
to
ae1c740
Compare
core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java
Show resolved
Hide resolved
...ent/src/main/java/io/quarkus/deployment/builditem/ConfigurationCustomConverterBuildItem.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @dmlloyd review it in depth but I added a few cosmetic comments.
core/runtime/src/main/java/io/quarkus/runtime/configuration/ConverterSupport.java
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkus/runtime/configuration/ConverterSupport.java
Outdated
Show resolved
Hide resolved
core/runtime/src/test/java/io/quarkus/runtime/configuration/ConverterSupportTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think after the priorities are added to our converters, this will be ready to go.
core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigurationSetup.java
Show resolved
Hide resolved
core/deployment/src/main/java/io/quarkus/deployment/steps/ConfigurationSetup.java
Show resolved
Hide resolved
core/runtime/src/main/java/io/quarkus/runtime/configuration/ConverterSupport.java
Show resolved
Hide resolved
Looks OK, thanks. |
Hello @dmlloyd,
This is a commit I prepared in regards to the problem we discussed on Zulip to address issue #702 you created in the past.