Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce lenient Duration converter #2452

Closed
dmlloyd opened this issue May 15, 2019 · 3 comments · Fixed by #2506
Closed

Introduce lenient Duration converter #2452

dmlloyd opened this issue May 15, 2019 · 3 comments · Fixed by #2506
Labels
area/config good first issue Good for newcomers
Milestone
0.16.0

Comments

@dmlloyd
Copy link
Member

dmlloyd commented May 15, 2019

The Converter should accept values which start with a number by implicitly appending a PT to them. If the value consists only of a number, it should implicitly treat the value as seconds.
@gsmet
Copy link
Member

gsmet commented May 16, 2019

@machi1990 would you be interested in taking this one?

The converter can already be written but I think we need to wait for #2399 to go in for the declaration as it changes the way converters are declared.

@gsmet gsmet added area/config good first issue Good for newcomers labels May 16, 2019
@machi1990
Copy link
Member

@gsmet sure.

I'll have a look once #2399 lands.

machi1990 added a commit to machi1990/quarkus that referenced this issue May 16, 2019
@machi1990
feat(quarkusio#2452): Add a linient Duration converter
87ad6d4
machi1990 added a commit to machi1990/quarkus that referenced this issue May 17, 2019
@machi1990
feat(quarkusio#2452): Add a linient Duration converter
818acb5
machi1990 added a commit to machi1990/quarkus that referenced this issue May 17, 2019
@machi1990
feat(quarkusio#2452): Add a linient Duration converter
943c28e
@machi1990
Copy link
Member

@gsmet @dmlloyd I started working on this issue. Your early feedback is welcomed.

machi1990 added a commit to machi1990/quarkus that referenced this issue May 18, 2019
@machi1990
feat(quarkusio#2452): Add a linient Duration converter
f5e0b46
machi1990 added a commit to machi1990/quarkus that referenced this issue May 18, 2019
@machi1990
feat(quarkusio#2452): change Duration configuration values to use a l…
c61cb34 
…inient Duration converter
machi1990 added a commit to machi1990/quarkus that referenced this issue May 18, 2019
@machi1990
feat(quarkusio#2452): Add a linient Duration converter
4ace444
machi1990 added a commit to machi1990/quarkus that referenced this issue May 18, 2019
@machi1990
feat(quarkusio#2452): change Duration configuration values to use a l…
4411732 
…inient Duration converter
@machi1990 machi1990 mentioned this issue May 18, 2019
Merged
machi1990 added a commit to machi1990/quarkus that referenced this issue May 18, 2019
@machi1990
feat(quarkusio#2452): Add a linient Duration converter
57097a5
machi1990 added a commit to machi1990/quarkus that referenced this issue May 18, 2019
@machi1990
feat(quarkusio#2452): change Duration configuration values to use a l…
cf474ea 
…inient Duration converter
machi1990 added a commit to machi1990/quarkus that referenced this issue May 19, 2019
@machi1990
feat(quarkusio#2452): Add a linient Duration converter
fdfe454
machi1990 added a commit to machi1990/quarkus that referenced this issue May 19, 2019
@machi1990
feat(quarkusio#2452): change Duration configuration values to use a l…
d311005 
…inient Duration converter
@gsmet gsmet added this to the 0.16.0 milestone May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/config good first issue Good for newcomers
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Add a linient Duration converter machi1990/quarkus
3 participants
@dmlloyd @gsmet @machi1990