fix(#2210): log a warning if a final method is skipped when generating client proxies and subclasses #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
requested changes
May 30, 2019
independent-projects/arc/processor/src/main/java/io/quarkus/arc/processor/Methods.java
Outdated
Show resolved
Hide resolved
Thanks for the review. Comments addressed. |
…generating client proxies and subclasses
mkouba
reviewed
May 30, 2019
| if (Modifier.isStatic(method.flags()) || Modifier.isFinal(method.flags()) || Modifier.isPrivate(method.flags())) { | ||
| short flags = method.flags(); | ||
| String className = method.declaringClass().name().toString(); | ||
| if (Modifier.isFinal(flags) && !className.startsWith("java.")) { |
There was a problem hiding this comment.
Hm, is there actually a reason to skip the message for JDK classes?
There was a problem hiding this comment.
To keep the logs to a minimum user related stuffs.
There was a problem hiding this comment.
Ok makes sense. User can define a producer for a JDK class but it's probably reasonable.
mkouba
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2210
@mkouba