Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build warnings when using quarkus-smallrye-health extension #2963

Closed
gastaldi opened this issue Jun 25, 2019 · 3 comments · Fixed by #2973
Closed

Build warnings when using quarkus-smallrye-health extension #2963

gastaldi opened this issue Jun 25, 2019 · 3 comments · Fixed by #2973
Assignees
Labels
area/arc Issue related to ARC (dependency injection) kind/bug Something isn't working
Milestone

Comments

@gastaldi
Copy link
Contributor

Describe the bug
The following warnings are shown during the build:

[WARNING] [io.quarkus.arc.processor.Methods] Method io.smallrye.health.SmallRyeHealthReporter.getHealth() is final, skipped during generation of corresponding intercepted subclass
[WARNING] [io.quarkus.arc.processor.Methods] Method io.smallrye.health.SmallRyeHealthReporter.getHealth() is final, skipped during generation of corresponding client proxy

Expected behavior
No warnings

Actual behavior
Warning is shown

To Reproduce
Steps to reproduce the behavior:
1.

 mvn io.quarkus:quarkus-maven-plugin:0.17.0:create \
    -DprojectGroupId=org.acme \
    -DprojectArtifactId=getting-started \
    -DclassName="org.acme.quickstart.GreetingResource" \
    -Dpath="/hello" \
    -Dextensions="quarkus-smallrye-health"
  1. cd getting-started
  2. mvn package

Environment (please complete the following information):

  • Output of uname -a or ver: Linux ggastald-laptop 5.1.6-300.fc30.x86_64 #1 SMP Fri May 31 17:43:23 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
  • Output of java -version:
openjdk version "1.8.0_212"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_212-b03)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.212-b03, mixed mode)
  • GraalVM version (if different from Java): Not installed
  • Quarkus version or git rev: 0.17.0
@gastaldi gastaldi added the kind/bug Something isn't working label Jun 25, 2019
@machi1990
Copy link
Member

@gastaldi the warning is expected: introduce by this PR #2644.

@gastaldi
Copy link
Contributor Author

@machi1990 I am not saying that the warning shouldn't exist, but I think the smallrye-health extension needs to be enhanced to not trigger that warning, no?

@mkouba
Copy link
Contributor

mkouba commented Jun 26, 2019

Moreover, this method is private and should be completely ignored.

@mkouba mkouba self-assigned this Jun 26, 2019
@mkouba mkouba added the area/arc Issue related to ARC (dependency injection) label Jun 26, 2019
@gsmet gsmet added this to the 0.18.0 milestone Jun 26, 2019
mkouba added a commit to mkouba/quarkus that referenced this issue Jun 26, 2019
dmlloyd pushed a commit to dmlloyd/quarkus that referenced this issue Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants