-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netflix Button Addition #159
Conversation
[Helix][rebrand] Nuke some more XBMC links and references
(cherry picked from commit d90cb8a)
woa - use profile path
dvdplayer: make sure overlay container is cleared when player stops
DXVA: add HD5xxx to ati work-around, only capable of opening a single t...
[Fix] Mem leaks helix
[release] bump to Helix 14.0 final
CFile: Don't cast potential negative values to unsigned int
Helix versiontag
[videoinfoscanner] fix shows not picked up after initial scan abort
[release] bump to 14.2 final
Speeds up menu browsing quite a bit. Subtitle glitch improved slightly.
Added previously unrecognized key command for Netflix-button Boxee Boxes. Mapped to Contextual Menu.
@zang74 Great work,I have uploaded a test build so you can confirm it works your end, I have tested here (I don't have the Netflix button but everything appears to work fine, no regressions). |
Hi, I’ve tested, but am getting nothing. That said, the file creation date/time of the Kodi.bin you sent is March 27th, the same as the last release. Is it possible I got the old build?
|
@zang74 Yes looks like I packaged the wrong kodi.bin. |
That did it! It works as expected.
|
Great, do you mind doing the PR to quasar1 github Helix branch? |
Done.
|
Thanks, merged on the quasar1 github. |
Thanks! Wish I could be of more help. I'm no C++ coder; just a PHP guy who got tired of that damn button taunting me with its impotence and did some sleuthing. Also; any idea how I'd get past the read-only tag to shoehorn the new binary into my internal install, or should I ask Orizzle?
|
I'm no C++ coder, just sheer determination, dedication, trial an error and research. I am not sure how the internal install works not tried it. You may be able to browse the Boxee Box using WinSCP FTP/Putty and change the file permissions that way. I'm hoping to do another release with your changes at some point, in the middle of attempting a subtitle glitch fix. |
@zang74 |
Just discovered something interesting, Quasar. Apparently, Kodi is logging debug notifications even when all logging is turned off in advancedsettings.xml using . The build is a debug build, [23:07:18 T:3038897888 NOTICE: Using Debug Kodi x32 build] and thus that logging cannot be turned off without a recompile. Apparently there was a similar issue with the Android version, and there's a thread about it here: http://forum.kodi.tv/showthread.php?tid=207278&page=1 This leads into: I run my BBs 24/7, and I've also discovered that log files are being buffered somewhere before being written to kodi.log, as "cat /dev/null > kodi.log" will empty the log file, but within a minute the file will be re-written with all the info that was just erased. I saw this happen with an 11.6MB log file. If this is being stored in RAM, this could be an issue, and could be slowly eating RAM the longer the machine remains on, and could be causing some of the RAM issues recent builds have had. I can't see buffering ~12MB of log files an efficient use of memory. |
@zang74 More info here: |
Be aware quarnster enabled allot of logging option for video part, intel smd etc debug, think if you can disable that it will run allot better. Dont think you need it anymore(there are no devs that can fix that part of errors) |
Apparently, in release builds one can disable logging altogether by using the loglevel tag in advancedsettings.xml. I tried this (loglevel -1) after trying loglevel 0 (just notices errors, no debug comments), only to discover that neither worked. This is apparently because the build is set as a debug build and not a release build, meaning debugging is turned on by default and turning it off is disabled. This may also be why it often creates insanely large log files without offloading to kodi.old.log. As it is now, the log file will continue to grow with every debug notice (and that includes every keypress, loading of GUI elements, etc.) with no end until the machine is rebooted. |
@devil-strike Yes you are absolutely right. Looks like we aren't going to get any further dev help regarding Intel SMD so must make best of what we have. @zang74 I have just compiled a test build, I will upload it shortly for you to try. BTW. Can someone direct Orizzle in this post http://boxeed.in/forums/viewtopic.php?f=13&t=1273 to quasar1#12 I have opened 'issues' on the quasar1 github, thanks. |
I finally got a chance to test this version. The debugging messaging appears to have stopped, and confluence appears markedly faster—I'm guessing because it's not having to write every GUI element load or keypress to log. Library scanning and launching of videos is slower, but I'm chalking that up to testing Kodi and its db entirely off a slow USB key (my main install is internal and I use a networked MariaDB server for the database). None of the log messages seem terribly out of the ordinary though. |
There's a noticeable difference even with default with just debugging off. |
Added missing key command for Netflix-Button Boxee Boxes.