Bad error message on invalid YAML

[schochastics]

Bug description

On my quarto page, I have utterance activated on 2 docs. On these two pages I have the following in my yaml header which has worked at least until quarto 1.1.128

comments:
  utterances:
    repo: schochastics/quarto-schochastics
    issue-term: pathname
    label: comment
    theme: photon-dark
    crossorigin: anonymous

Starting with quarto 1.1.178 I get this error when rendering

ERROR: Validation of YAML front matter failed.
ERROR: In file material/netVizR/index.qmd
(line 13, column 3 through line 18, column 26) Key comments has value utterances:
    repo: schochastics/quarto-schochastics
...
    theme: photon-dark
    crossorigin: anonymous, which must be 'false'
12: comments:
13:   utterances:
      ~~~~~~~~~~~
14:     repo: schochastics/quarto-schochastics
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
17:     theme: photon-dark
    ~~~~~~~~~~~~~~~~~~~~~~
18:     crossorigin: anonymous
    ~~~~~~~~~~~~~~~~~~~~~~~~~
19: ---

ERROR: Render failed due to invalid YAML.

I did not change any code just wanted to re-render after installing the new quarto version
I am running Ubuntu 20.04

Checklist

• Please include a minimal, fully reproducible example in a single .qmd file? Please provide the whole file rather than the snippet you believe is causing the issue.
• Please format your issue so it is easier for us to read the bug report.
• Please document the RStudio IDE version you're running (if applicable), by providing the value displayed in the "About RStudio" main menu dialog?
• Please document the operating system you're running. If on Linux, please provide the specific distribution.

[cderv]

I think we did some change to be more strict on YAML schema and validation.

I don't think you need to provide crossorigin: anonymous. It is not among the known options (https://quarto.org/docs/reference/projects/websites.html#utterances) and I think it will be added as anonymous by default.

quarto-cli/src/resources/formats/html/utterances/utterances.ejs

Line 5 in aad8a99

crossorigin="anonymous"

So I would just remove that field. Does that work ?

[schochastics]

yep that does the trick, thanks!

[cderv]

@cscheid Just wondering if we could / should try to improve the error message for a field that is not in the schema ?

quarto-cli/src/resources/schema/definitions.yml

Lines 127 to 167 in bb2d57b

	utterances:
	object:
	closed: true
	properties:
	repo:
	string:
	description: The Github repo that will be used to store comments.
	label:
	string:
	description: The label that will be assigned to issues created by Utterances.
	theme:
	string:
	description:
	short: The Github theme that should be used for Utterances.
	long: |
	The Github theme that should be used for Utterances
	(`github-light`, `github-dark`, `github-dark-orange`,
	`icy-dark`, `dark-blue`, `photon-dark`, `body-light`,
	or `gruvbox-dark`)
	completions:
	- github-light
	- github-dark
	- github-dark-orange
	- icy-dark
	- dark-blue
	- photon-dark
	- body-light
	- gruvbox-dark
	issue-term:
	string:
	description:
	short: How posts should be mapped to Github issues
	long: |
	How posts should be mapped to Github issues
	(`pathname`, `url`, `title` or `og:title`)
	completions:
	- pathname
	- url
	- title
	- og:title
	required: [repo]

Current error seems to be

crossorigin: anonymous, which must be 'false'

Not sure so hence I am asking before reopening or not. thanks !

[cscheid]

Yes, that error is atrocious. Thanks for flagging. Let me see if I can figure out why it's coming up like that.

[cscheid]

Previous error message:

ERROR: Validation of YAML front matter failed.
ERROR: In file issue-2349.qmd
(line 3, column 3 through line 8, column 26) Field "comments" has value

utterances:
  repo: schochastics/quarto-schochastics
...
  theme: photon-dark
  crossorigin: anonymous

The value must instead be 'false'.
2: comments:
3:   utterances:
     ~~~~~~~~~~~
4:     repo: schochastics/quarto-schochastics
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
7:     theme: photon-dark
   ~~~~~~~~~~~~~~~~~~~~~~
8:     crossorigin: anonymous
   ~~~~~~~~~~~~~~~~~~~~~~~~~
9: ---

ERROR: Render failed due to invalid YAML.

Yuck.

New error message:

ERROR: Validation of YAML front matter failed.
ERROR: In file issue-2349.qmd
(line 8, columns 5--16) property name crossorigin is invalid
7:     theme: photon-dark
8:     crossorigin: anonymous
       ~~~~~~~~~~~
9: ---
ℹ The error happened in location comments:utterances:crossorigin.

Yay! Pull request incoming.

[cderv]

🤯 so good ! Really cool improvement! 👏