FontAwesome 6.4.2 Update #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0 to 9 were missing, manually added
|
Hey Phil, this looks excellent, thank you so much! I think that for larger PRs like this, we need you to file a contributor agreement with Posit. Can you follow the instructions on https://github.com/quarto-dev/quarto-cli/blob/main/CONTRIBUTING.md and confirm on a reply here that you've done so? |
|
Hey Carlos,
please find attached the document (I put the email-address from contributing in CC). So, I need to re-do the pull request according to contributin.md, right?
All the best
Phil

… Am 22.09.2023 um 17:07 schrieb Carlos Scheidegger ***@***.***>:
Hey Phil, this looks excellent, thank you so much! I think that for larger PRs like this, we need you to file a contributor agreement with Posit. Can you follow the instructions on https://github.com/quarto-dev/quarto-cli/blob/main/CONTRIBUTING.md and confirm on a reply here that you've done so?
—
Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARI2FFOTVNNOFXW74C6LRATX3WSUFANCNFSM6AAAAAA5DF5MAM>.
You are receiving this because you authored the thread.
|
|
No, no need to redo the pull request! |
|
LGTM, thanks for the contribution! |
|
You’re welcome. I heavily use it. Thanks for providing and maintaining it!
… Am 22.09.2023 um 19:19 schrieb Carlos Scheidegger ***@***.***>:
LGTM, thanks for the contribution!
—
Reply to this email directly, view it on GitHub <#32 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ARI2FFMEPKT7YDG4IAJPCSDX3XCBBANCNFSM6AAAAAA5DF5MAM>.
You are receiving this because you authored the thread.
|
This was
linked to
issues
Nov 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
I saw that the issue and task for implementing 6.4.2 is still open (#28). Since I needed 6.4.2 support for my presentation (new twitter logo), I updated the .css-files to 6.4.2 and the ttf/woff2 files. In case this might help you or is interesting to you, use it!
All the best
Phil