Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Добавлен компонент **TimerCircle** #246

Merged
merged 1 commit into from
Jul 10, 2023
Merged

feat: Добавлен компонент **TimerCircle** #246

merged 1 commit into from
Jul 10, 2023

Conversation

ISAYwtf
Copy link
Contributor

@ISAYwtf ISAYwtf commented Jun 19, 2023

No description provided.

@ISAYwtf ISAYwtf added the enhancement New feature or request label Jun 19, 2023
@ISAYwtf ISAYwtf self-assigned this Jun 19, 2023
@ISAYwtf ISAYwtf changed the base branch from main to feat/Alert June 19, 2023 07:01
@github-actions
Copy link

github-actions bot commented Jun 19, 2023 •
edited
Loading

Storybook

aak-lear
aak-lear requested changes Jun 19, 2023
View reviewed changes
packages/core/utils/hooks/useTimer/types.ts Outdated Show resolved Hide resolved
packages/core/utils/hooks/useTimer/types.ts Outdated Show resolved Hide resolved
packages/core/utils/hooks/useTimer/types.ts Outdated Show resolved Hide resolved
packages/core/utils/hooks/useTimer/types.ts Outdated Show resolved Hide resolved
packages/core/utils/hooks/useTimer/types.ts Outdated Show resolved Hide resolved
packages/core/utils/hooks/useTimer/types.ts Outdated Show resolved Hide resolved
packages/core/src/system/TimerCircle/styles/index.ts Outdated Show resolved Hide resolved
packages/core/src/system/TimerCircle/storybook/circleSegments/index.tsx Outdated Show resolved Hide resolved
packages/core/src/system/TimerCircle/TimerCircle.tsx Outdated Show resolved Hide resolved
@ISAYwtf ISAYwtf requested a review from aak-lear June 19, 2023 12:00
@ISAYwtf ISAYwtf force-pushed the feat/Alert branch 2 times, most recently from 7697530 to 2507e1a Compare June 21, 2023 07:24
@maximzadorkin
Copy link
Contributor

Странно, что на таймере 0, а еще происходит движение полосы
image

@ISAYwtf
Copy link
Contributor Author

ISAYwtf commented Jul 3, 2023 •
edited
Loading

Странно, что на таймере 0, а еще происходит движение полосы image

Согласен, это происходит из-за того, что анимация построена на обычном transition, в старом ките чтобы решить эту проблему заранее отнимали одну единицу, чтобы анимация была как бы впереди на одну секунду, но это порождало другие проблемы. То есть по сути здесь нужно думать как правильно анимацию строить, может подумать в сторону requestAnimationFrame

Base automatically changed from feat/Alert to main July 3, 2023 06:19
@ISAYwtf ISAYwtf force-pushed the feat/TimerCircle branch 2 times, most recently from 665c72c to 29afcab Compare July 6, 2023 14:36
@ISAYwtf ISAYwtf requested a review from aak-lear July 6, 2023 14:48
@maximzadorkin
Copy link
Contributor

Не знаю будешь решать в этом ПР или в отдельном проблемы с анимацией, но апрув сейчас тогда проставлю. Потом если починишь в этом ПР еще гляну

@ISAYwtf
Copy link
Contributor Author

ISAYwtf commented Jul 10, 2023

Не знаю будешь решать в этом ПР или в отдельном проблемы с анимацией, но апрув сейчас тогда проставлю. Потом если починишь в этом ПР еще гляну

Поправлю в отдельном

@ISAYwtf ISAYwtf merged commit 3355ca8 into main Jul 10, 2023
@ISAYwtf ISAYwtf deleted the feat/TimerCircle branch July 10, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aak-lear aak-lear aak-lear approved these changes

@maximzadorkin maximzadorkin maximzadorkin approved these changes

Assignees

@ISAYwtf ISAYwtf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ISAYwtf @maximzadorkin @aak-lear