Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: injected sql model now uses chart name instead of random ID for improved error message #275

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: injected sql model now uses chart name instead of random ID for improved error message #275

merged 1 commit into from
May 23, 2024

Conversation

louisjoecodes
Copy link
Contributor

@louisjoecodes louisjoecodes commented May 23, 2024 •
edited
Loading

  • Instead of using a random ID for the injected SQL models, just use the Chart file name
  • This is guaranteed to be unique as 2 charts should not have the same name

@louisjoecodes louisjoecodes force-pushed the fix/improve_templated_sql_error_message branch from 9e9793a to b4f9460 Compare May 23, 2024 09:37
@louisjoecodes louisjoecodes mentioned this pull request May 23, 2024
Merged
@louisjoecodes louisjoecodes force-pushed the fix/improve_templated_sql_error_message branch 2 times, most recently from 5cd235b to 48aa059 Compare May 23, 2024 09:46
benfdking
benfdking approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@benfdking benfdking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little things that would make the reason for the change in API slightly more explicit.

rust/core/src/project_to_sql.rs Show resolved Hide resolved
rust/core/src/project_to_sql.rs Outdated Show resolved Hide resolved
proto/quary/service/v1/wasm_rust_rpc_calls.proto Outdated Show resolved Hide resolved
@louisjoecodes louisjoecodes force-pushed the fix/improve_templated_sql_error_message branch 4 times, most recently from 57d81d5 to 11f4f8a Compare May 23, 2024 11:05
@louisjoecodes louisjoecodes force-pushed the fix/improve_templated_sql_error_message branch from 11f4f8a to 3fa3465 Compare May 23, 2024 11:11
@louisjoecodes
Copy link
Contributor Author

  • Nits resolved
  • Throw error (to trigger sentry) if file-name/chart name retrieval fails

@louisjoecodes louisjoecodes added this pull request to the merge queue May 23, 2024
@louisjoecodes louisjoecodes removed this pull request from the merge queue due to a manual request May 23, 2024
@louisjoecodes louisjoecodes added this pull request to the merge queue May 23, 2024
@louisjoecodes louisjoecodes removed this pull request from the merge queue due to a manual request May 23, 2024
@louisjoecodes louisjoecodes merged commit bd364c8 into main May 23, 2024
11 checks passed
@benfdking benfdking deleted the fix/improve_templated_sql_error_message branch May 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benfdking benfdking Awaiting requested review from benfdking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisjoecodes @benfdking