-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding burn contract. #585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
state should be a bit cleaner, but general structure looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one nitpick comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an open discussion to KISS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 small comments that I missed first time around, otherwise LGTM
a253ac9
to
a665b16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
1. Overview
In this PR we are adding Burn contract that will burn the token sent to it.
2. Implementation details
The Burn Coins Contract is a simple smart contract designed to burn the coins sent to it. Here are some highlights of the implementation:
instantiate
function to initialize the contract.execute
function that hasburn
function to handle the execution of coin burning.query
function.Design Rationale:
3. How to test/use
To test or use the Burn Coins Contract, follow these steps:
sh quasar_localnet.sh
burn.sh
4. Checklist
5. Limitations (optional)
6. Future Work (optional)
Potential future enhancements for the Burn Coins Contract include: