-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application: support -cfgfile besides --cfgfile (like Appconfig would) #112
Application: support -cfgfile besides --cfgfile (like Appconfig would) #112
Conversation
f303a37
to
7a28f61
Compare
@@ -61,6 +61,16 @@ is($newapp->option($OPTION_CFGFILE), $cfgfile, | |||
is($newapp->option('myoption'), $value, | |||
"myoption value from configfile"); | |||
|
|||
# 1st format short -cfgile path/tofile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-cfgfile
7a28f61
to
1e1c5a4
Compare
@jrha typos fixed |
# 2nd format --cfgile=path/to/file | ||
$configfile = $1 if ($arg =~ m/$cfgfile_value_pattern/); | ||
if ($arg =~ m/$cfgfile_value_pattern/) { | ||
if(defined($1)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace between if
and (
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, even easier, why don't you just split
by the =
sign?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how will it be easier? will still need the regexp i think
1e1c5a4
to
92a985b
Compare
…cfgfile CAF::Application: support -cfgfile besides --cfgfile (like Appconfig would)
Fixes #113